-
Notifications
You must be signed in to change notification settings - Fork 479
[Qin Nanxin] iP #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
InfiBeyond
wants to merge
76
commits into
nus-cs2103-AY2324S1:master
Choose a base branch
from
InfiBeyond:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Qin Nanxin] iP #572
Changes from 1 commit
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
28ad2b8
Add Gradle support
ed6d4d2
Bump gradle and lib version
Eclipse-Dominator abfac81
[Level 0. Rename, Greet, Exit]
InfiBeyond 517a3a2
[Level 1. Echo]
InfiBeyond 5130bfd
[Level 2. Add, List]
InfiBeyond 5823330
[Level 3. Mark as Done]
InfiBeyond 59f198a
[Level 4. ToDos, Events, Deadlines]
InfiBeyond 5f799dd
[Automated Text UI Testing]
InfiBeyond 227c818
[Level 5. Handle Errors]
InfiBeyond c8a51aa
[Level 6. Delete]
InfiBeyond b60464f
Add DukeException class
InfiBeyond fb28447
Previous files corrupted -> Have to fork project again [Level-0]
InfiBeyond cb37643
[Level 1. Echo]
InfiBeyond 06d749e
[Level 2. Add, List]
InfiBeyond ccefdd8
[Level 3. Mark as Done]
InfiBeyond c5e5035
[Level 4. ToDos, Events, Deadlines]
InfiBeyond f6fa252
[Level 5. Handle Errors]
InfiBeyond 268ecd1
[Level 6. Delete]
InfiBeyond ec71f5a
[Level 7. Save]
InfiBeyond 2832520
Merge branch 'branch-Level-7'
InfiBeyond 8e0a3da
[Level 8. Dates and Times
InfiBeyond bc254bf
Merge branch 'branch-Level-8'
InfiBeyond bc20f51
[Level 8. Dates and Times]
InfiBeyond 5591645
Merge branch 'branch-Level-8'
InfiBeyond 90fb38b
OOP part 1
InfiBeyond b0c2294
[A-MoreOOP]
InfiBeyond e1e5352
Merge branch 'branch-A-MoreOOP'
InfiBeyond 1b46958
[A-Packages]
InfiBeyond 60851c5
Merge branch 'branch-A-Packages'
InfiBeyond 9ee8913
Merge branch 'add-gradle-support'
InfiBeyond 13f7891
Fix renaming import package error
InfiBeyond 0915f76
[A-Gradle]
InfiBeyond f1b52a4
[A-JUnit]
InfiBeyond 48e1b39
Merge branch 'branch-A-JUnit'
InfiBeyond 3e9730d
[A-Jar]
InfiBeyond e3f32d4
[A-JavaDoc]
InfiBeyond 4ef7983
[A-CodingStandard]
InfiBeyond cbba5e0
[Level 9. Find]
InfiBeyond 14daed2
Merge branch 'branch-A-JavaDoc'
InfiBeyond 454b9ec
Merge branch 'branch-A-CodingStandard'
InfiBeyond 83021ff
Merge branch 'branch-Level-9'
InfiBeyond 202d315
[A-CheckStyle]
InfiBeyond 3a6c213
Merge branch 'branch-A-CheckStyle'
InfiBeyond f270bbc
[Level 10. GUI]
InfiBeyond 87585ce
[Level 10. GUI]
InfiBeyond 0264fab
Add MainWindow.java
InfiBeyond 64cd33a
Merge branch 'branch-Level-10'
InfiBeyond 677a0a3
Generate a new JAR file using Gradle
InfiBeyond e9c434c
[A-Assertions]
InfiBeyond c9b3825
[A-CheckStyle]
InfiBeyond e62e810
Merge pull request #2 from InfiBeyond/branch-A-Assertions
InfiBeyond 9c23bc9
Merge branch 'master' of https://github.com/InfiBeyond/ip
InfiBeyond f1ca54a
Merge pull request #3 from InfiBeyond/branch-A-CodeQuality
InfiBeyond 59dedbd
Merge branch 'master' of https://github.com/InfiBeyond/ip
InfiBeyond 7c5fc1f
[C-DetectDuplicates]
InfiBeyond 8cc478f
Merge branch 'branch-C-DetectDuplicates'
InfiBeyond 69a2e5d
Fix GUI for display text by changing height and width.
InfiBeyond 96b6642
Merge branch 'branch-A-BetterGui'
InfiBeyond 17e9d8b
Add Ui.png
InfiBeyond 066511a
Update README.md
InfiBeyond 34a161e
Update README.md
InfiBeyond 22fc82a
Merge branch 'master' of https://github.com/InfiBeyond/ip
InfiBeyond 91503fa
Update GUI
InfiBeyond 77e2a1d
Update GUI
InfiBeyond 47711eb
Fix missing Ui.png
InfiBeyond ca6addc
Update UI.png location
InfiBeyond 618da5b
Fix styling errors
InfiBeyond f7d2b25
Update README.md
InfiBeyond 6182e16
Update README.md
InfiBeyond ad511a3
Update README.md
InfiBeyond a87b8a8
Update README.md
InfiBeyond c77c2bb
Update README.md
InfiBeyond 27af30c
Improve JUnit Testing
InfiBeyond 55a69f3
Update Jar file
InfiBeyond 699769d
Update credits for code Reuse
InfiBeyond 722c222
Update credits for code reuse
InfiBeyond File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,6 +26,10 @@ public static void main(String[] args) { | |
| int unmarkItem = sc.nextInt(); | ||
| taskList.get(unmarkItem - 1).markUndone(); | ||
| break; | ||
| case "delete": | ||
|
||
| int deleteItem = sc.nextInt(); | ||
| delete(deleteItem); | ||
| break; | ||
| case "todo": | ||
| add(new ToDo(sc.nextLine())); | ||
| break; | ||
|
|
@@ -68,6 +72,13 @@ public static void add(Task input) { | |
| System.out.println("Current # of task: " + taskList.size()); | ||
| } | ||
|
|
||
| public static void delete(int num) { | ||
| System.out.println("I've removed this task:"); | ||
| taskList.get(num-1).getStatus(); | ||
| taskList.remove(num - 1); | ||
| System.out.println("Now you have " + taskList.size() + " tasks in the list."); | ||
| } | ||
|
|
||
| public static void print() { | ||
| int index = 1; | ||
| for (Task task: taskList) { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation for the case blocks inside the switch statement within the try block does not follow the coding standard