[Lee Miao En Emelyn] iP #442
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate BROWNIE responses
potatoems
changed the title
NhatMinh0208
reviewed
Feb 5, 2025
| @@ -0,0 +1,102 @@ | |||
| import java.util.Scanner; | |||
|
|
|||
There was a problem hiding this comment.
Most of the public methods and classes are missing a Javadoc comment. Perhaps you can add comments to at least the classes?
| @@ -0,0 +1,102 @@ | |||
| import java.util.Scanner; | |||
|
|
|||
| public class Brownie{ | |||
There was a problem hiding this comment.
I think there should be a space before the brackets here?
Comment on lines
+71
to
+85
| throw new DukeException("Hello! Can I confirm what task you would like to note down?\n" + | ||
| "ToDo tasks must look like: todo xxxxxxxx"); | ||
| } | ||
| tasks.add(taskDescription.substring(5), 'T'); | ||
| System.out.println(horizontalLine); | ||
| } else if (taskDescription.startsWith("event")) { | ||
| if (scriptLength < 7) { | ||
| throw new DukeException("Hello! Can I confirm what task you would like to note down?\n" + | ||
| "Event tasks must look like: event xxxxxxxx /from xxx /to xxx"); | ||
| } | ||
| tasks.add(taskDescription.substring(6), 'E'); | ||
| System.out.println(horizontalLine); | ||
| } else if (taskDescription.startsWith("deadline")) { | ||
| if (scriptLength < 10) { | ||
| throw new DukeException("Hello! Can I confirm what task you would like to note down?\n" + |
There was a problem hiding this comment.
Can you push the + down to the following line?
| public void deleteTask(int taskNumber) { | ||
| Task task = tasks.get(taskNumber); | ||
| tasks.remove(taskNumber - 1); | ||
| System.out.println("Noted. I've removed this task:\n" + task + "\nNow you have " + tasks.size() + " tasks in the list."); |
There was a problem hiding this comment.
This line is just a littttle bit too long. Can you split it into two?
| import java.util.Scanner; | ||
|
|
||
| public class Brownie{ | ||
| private static final String horizontalLine = "____________________________________________________________"; |
There was a problem hiding this comment.
This is a constant, right? So I think the name should be HORIZONTAL_LINE?
Comment on lines
+10
to
+11
| String greeting = "\nHello! I'm BROWNIE\nWhat can I do for you?\n"; | ||
| String farewell = "Bye. Hope to see you again soon!\n"; |
There was a problem hiding this comment.
And these strings are constants, too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.