[Wong Zenwei] iP

[zeotheburrito]

[Wong Zenwei] iP Pull Request

Features

• Show to-do list
• Add task to to-do list
• Mark tasks as done

Steps for next increment

1. Follow the tutorial here
2. Get the required scripts from text-ui-test in Duke repo

while (true) {
  // keep going!
}

Increments to be done 😭

• A-TextUiTesting
• Level-5
• Level-6
• A-Enums
• Level-7
• Level-8
• A-MoreOOP
• A-Packages
• A-Gradle
• A-JUnit
• A-Jar
• A-JavaDoc
• A-CodingStandard
• Level-9
• A-CheckStyle
• Level-10
• A-Varargs

If at first you don't succeed, try, try again

[cyhni]

Good job so far, a clean base code to work on going forward.
Some minor coding standard changes requested.

[cyhni]

The switch statement should have no indentation for case clauses according to coding standard

Suggested change

	switch (parsed[0]) {
	case "list":
	String items = "";
	for (int i = 0; i < list.size(); i++) {
	items += " " + (i + 1) + ". " + list.get(i) + "\n";
	}
	message = "____________________________________________________________\n" +
	" Here are the tasks in your list:\n" +
	items +
	"____________________________________________________________\n";
	break;
	case "mark":
	int index = Integer.parseInt(parsed[1]) - 1;
	list.get(index).setDone();
	message = "____________________________________________________________\n" +
	" Nice! I've marked this task as done:\n" +
	" " + list.get(index) + "\n" +
	"____________________________________________________________\n";
	break;
	case "unmark":
	int ind = Integer.parseInt(parsed[1]) - 1;
	list.get(ind).setNotDone();
	message = "____________________________________________________________\n" +
	" OK, I've marked this task as not done yet:\n" +
	" " + list.get(ind) + "\n" +
	"____________________________________________________________\n";
	break;
	default:
	list.add(new Task(input));
	message = "____________________________________________________________\n" +
	" added: " + input + "\n" +
	"____________________________________________________________\n";
	}
	switch (parsed[0]) {
	case "list":
	String items = "";
	for (int i = 0; i < list.size(); i++) {
	items += " " + (i + 1) + ". " + list.get(i) + "\n";
	}
	message = "____________________________________________________________\n" +
	" Here are the tasks in your list:\n" +
	items +
	"____________________________________________________________\n";
	break;
	case "mark":
	int index = Integer.parseInt(parsed[1]) - 1;
	list.get(index).setDone();
	message = "____________________________________________________________\n" +
	" Nice! I've marked this task as done:\n" +
	" " + list.get(index) + "\n" +
	"____________________________________________________________\n";
	break;
	case "unmark":
	int ind = Integer.parseInt(parsed[1]) - 1;
	list.get(ind).setNotDone();
	message = "____________________________________________________________\n" +
	" OK, I've marked this task as not done yet:\n" +
	" " + list.get(ind) + "\n" +
	"____________________________________________________________\n";
	break;
	default:
	list.add(new Task(input));
	message = "____________________________________________________________\n" +
	" added: " + input + "\n" +
	"____________________________________________________________\n";
	}

[cyhni]

When wrapping lines, break should be before an operator.
I noticed this issues in several other places as well.
Do take note!

Suggested change

	String greetings = "____________________________________________________________\n" +
	" Hello! I'm Jeff\n" +
	" What can I do for you?\n" +
	"____________________________________________________________\n";
	String greetings = "____________________________________________________________\n"
	+ " Hello! I'm Jeff\n"
	+ " What can I do for you?\n"
	+ "____________________________________________________________\n";

[cyhni]

Perhaps this should be sorted in alphabetical order?

[cyhni]

Good intuition to abstract the Task class! 👍

[cyhni]

If I recall correctly, variable names for boolean should be named like a boolean.
e.g use a prefix such as is, has, was

[cyhni]

Maybe it might be easier in the future to extract the print line to keep as a constant.