[Vincent Lau Han Leong] iP by vincentlauhl · Pull Request #183 · nus-cs2113-AY2122S1/ip

vincentlauhl · 2021-09-01T06:36:01Z

No description provided.

Jiale-Sun

The codes are of precision with accurate format of coding as well as appropriate naming.

Jiale-Sun · 2021-09-02T01:43:39Z

src/main/java/Deadline.java

@@ -0,0 +1,15 @@
+public class Deadline extends Task{


A minor code improvement: add a space before the "{"

Jiale-Sun · 2021-09-02T01:50:14Z

src/main/java/Duke.java

+        case TODO:
+            parsedOutput = new String[]{input};
+            break;
+


Perhaps you could delete the empty line between each case in the switch function. It was not shown in the lectures. Also, I think it is better to keep the consistency of format (since you did not add any empty line before or after this).

rizemon · 2021-09-02T02:54:29Z

src/main/java/Duke.java

+        if(input.length() != 6) {
+            printIncorrectInputMessage();
+            return;
+        }


Good use of this guard clause and I am able to see the "good path" of the method.

rizemon · 2021-09-02T03:02:29Z

src/main/java/Duke.java

+        switch(type) {
+        case TODO:
+            parsedOutput = new String[]{input};
+            break;
+
+        case DEADLINE:
+            parsedOutput = input.split(DEADLINE_DESCRIPTION_AND_DATE_SPLITTER);
+            break;
+
+        case EVENT:
+            parsedOutput = input.split(EVENT_DESCRIPTION_AND_DATE_TIME_SPLITTER);
+            break;
+        }


Perhaps you could add a default branch? The default branch can be used to raise a suitable error as I think the execution should not reach the default branch. I also noticed this same issue in your other switch statements.

rizemon · 2021-09-02T03:03:40Z

src/main/java/Duke.java

+    }
+
+    private static void processInput(String input) {
+        switch(input.split(" ")[0].toLowerCase()) {


Perhaps you could create a variable with a meaningful name to simplify the expression in the switch statement?

rizemon · 2021-09-02T03:12:42Z

src/main/java/Duke.java

+        switch(input.split(" ")[0].toLowerCase()) {
+        case "list" :
+            executeListCase();
+            break;
+        case "done" :
+            executeDoneCase(input);
+            break;
+        case "todo" :
+            executeTaskCase(input, TODO_STARTING_INDEX,TaskType.TODO);
+            break;
+        case "deadline" :
+            executeTaskCase(input, DEADLINE_STARTING_INDEX,TaskType.DEADLINE);
+            break;
+        case "event" :
+            executeTaskCase(input, EVENT_STARTING_INDEX,TaskType.EVENT);
+            break;
+        default :
+            printIncorrectInputMessage();


I like how the Single Level of Abstraction Principle is being applied here and I find it very easy to read and understand what you are trying to do.

kaiwen98 · 2021-09-15T02:13:43Z

src/main/java/duke/Duke.java

+        case "todo":
+            try {
+                executeTaskCase(input, TODO_STARTING_INDEX, TaskType.TODO);
+


Suggest to keep consistent the new line convention throughout the code.

kaiwen98 · 2021-09-15T02:14:35Z

src/main/java/duke/Duke.java

+        return parsedOutput;
+    }
+
+    private static void addTask(String input,TaskType type) throws StringIndexOutOfBoundsException, DukeException {


Suggest to relocate the function definition from "throw" onwards to a new line with appropriate line indent.

kaiwen98 · 2021-09-15T02:14:59Z

src/main/java/duke/Duke.java

+            tasks[Task.getTotalTasks()] = new ToDo(parsedOutput[0]);
+            break;
+        case EVENT:
+            if(parsedOutput.length < 2) {


Suggest to replace magic number with a well-named constant.

kaiwen98 · 2021-09-15T02:16:29Z

src/main/java/duke/Duke.java

+            printWordsWithIndentation(LIST_IS_EMPTY);
+        }
+        for (int i = 0; i < Task.getTotalTasks(); i++) {
+            printWordsWithIndentation(i + 1 + "." + tasks[i].getStatusIconAndDescription());


Suggest to relocate expression in function argument to a separate line with appropriate comments.

kaiwen98 · 2021-09-15T02:20:36Z

src/main/java/duke/Duke.java

+        if(input.length() < 6) {
+            throw new DukeException();
+        }
+        int index = Integer.parseInt(input.split(" ")[1]) - 1;


Suggest to replace magic number with a well named constant.

…m starts

# Conflicts: # src/main/java/duke/Duke.java # src/main/java/task/Task.java

Add date and time for event and deadline and some constants

# Conflicts: # src/main/java/commands/PrintOptions.java # src/main/java/parser/Parser.java # src/main/java/tasklist/TaskList.java # src/main/java/ui/Ui.java

Branch level 9

# Conflicts: # src/main/java/commands/AddCommand.java # src/main/java/commands/DeleteCommand.java # src/main/java/commands/DoneCommand.java # src/main/java/commands/IncorrectCommand.java # src/main/java/commands/ListCommand.java # src/main/java/duke/Duke.java # src/main/java/parser/Parser.java # src/main/java/task/Deadline.java # src/main/java/task/Event.java

Branch A-JavaDoc

vincentlauhl added 6 commits August 18, 2021 10:49

Add Greet

cbf3cd2

Add echo and method for printing output

91ce339

Add list keeping and list printing

e4f50de

Add Task class and Mark as Done feature

39dbc7c

Change taskList to tasks

b287fd9

Change constant to upper case

b6db002

vincentlauhl closed this Sep 1, 2021

vincentlauhl reopened this Sep 1, 2021

vincentlauhl changed the title ~~Vincent Lau Han Leong iP~~ [Vincent Lau Han Leong] iP Sep 1, 2021

vincentlauhl added 3 commits September 1, 2021 21:49

Add Event, ToDo, Deadline class and TaskType enum.

ab47db6

Add text UI testing

026be10

Update text ui test and done refactoring

5da062e

Jiale-Sun reviewed Sep 2, 2021

View reviewed changes

rizemon reviewed Sep 2, 2021

View reviewed changes

vincentlauhl added 6 commits September 8, 2021 18:04

Add exception handling and exception class

14a2865

Change input and expected text for ui test

8d6b1e5

Move classes into packages and update runtest.bat

42969c1

Merge branch 'branch-Level-5'

46c8930

Add package duke and update readme and runtest.bat

8493d64

Merge branch 'branch-A-Packages'

974df0a

kaiwen98 reviewed Sep 15, 2021

View reviewed changes

vincentlauhl added 9 commits September 15, 2021 12:54

Change array to array list, tidy up code, and update text ui test.

3dc210f

Add delete task and update text ui test

a9902e7

Add save to file after termination and read from file when the progra…

7c89dda

…m starts

Merge branch 'branch-Level-6'

b9b174f

Merge branch 'branch-Level-7'

c254470

# Conflicts: # src/main/java/duke/Duke.java # src/main/java/task/Task.java

Add help message and add jar file

80a19f2

Add classes for OOP with main code untouched

c2ec413

Update the code to have OOP style

bcb0f12

Add date and time for event and deadline and some constants

10ef049

vincentlauhl and others added 18 commits September 26, 2021 17:15

Add find function to find tasks containining the description

861e928

Add javadocs to most classes and methods

d76441c

Merge pull request #1 from vincentlauhl/branch-Level-8

f01e19e

Add date and time for event and deadline and some constants

Merge branch 'master' into branch-Level-9

7200398

# Conflicts: # src/main/java/commands/PrintOptions.java # src/main/java/parser/Parser.java # src/main/java/tasklist/TaskList.java # src/main/java/ui/Ui.java

Merge pull request #2 from vincentlauhl/branch-Level-9

c0a0767

Branch level 9

Merge pull request #3 from vincentlauhl/branch-A-JavaDoc

ca92735

Branch A-JavaDoc

Update ReadMe file

45dc063

Do a minor change on the ReadMe file

540a897

Update ReadMe to correct GitHub Page ReadMe

31cc2eb

Correct GitHub Page ReadMe

6f942e9

Correct GitHub Page not bolding words

69ce26d

Correct GitHub Page not bolding words attempt 2.

086b7ec

Update doc/ReadMe and revert the other ReadMe. Update help mesage

4663af3

Slight change to doc/ReadMe

266610b

Update code to adhere to coding standards. Update error message.

c1dd736

Include error handling for general errors in reading file

2157f69

Correction on reused code format

4ebd498

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Vincent Lau Han Leong] iP#183

[Vincent Lau Han Leong] iP#183
vincentlauhl wants to merge 42 commits intonus-cs2113-AY2122S1:masterfrom
vincentlauhl:master

vincentlauhl commented Sep 1, 2021

Uh oh!

Jiale-Sun left a comment

Uh oh!

Jiale-Sun Sep 2, 2021

Uh oh!

Jiale-Sun Sep 2, 2021

Uh oh!

rizemon Sep 2, 2021 •

edited

Loading

Uh oh!

rizemon Sep 2, 2021

Uh oh!

rizemon Sep 2, 2021

Uh oh!

rizemon Sep 2, 2021

Uh oh!

kaiwen98 Sep 15, 2021

Uh oh!

kaiwen98 Sep 15, 2021

Uh oh!

kaiwen98 Sep 15, 2021

Uh oh!

kaiwen98 Sep 15, 2021

Uh oh!

kaiwen98 Sep 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

vincentlauhl commented Sep 1, 2021

Uh oh!

Jiale-Sun left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rizemon Sep 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rizemon Sep 2, 2021 •

edited

Loading