[Dyah Ayu Nurun Nafisah] iP by dyahnafisah · Pull Request #200 · nus-cs2113-AY2122S1/ip

dyahnafisah · 2021-09-04T12:46:22Z

No description provided.

kewenlok

Overall, good job in following the iP requirements and coding standards. There are a few areas of improvement that I pointed out for you to enhance your code. Keep up the good work!

kewenlok · 2021-09-17T12:38:58Z

src/main/java/duke/Duke.java

+        }
+    }
+
+    public static void exitProgram() {


Consider using consistent method names across similar methods. For example, since you named your welcome message method showWelcomeMessage(), your exit message method is recommended to be showExitMessage() so that it is more consistent and easier for other people to trace through your code.

kewenlok · 2021-09-17T12:43:14Z

src/main/java/duke/Duke.java

@@ -0,0 +1,184 @@
+package duke;
+
+import duke.exceptions.*;


You should import only the libraries that you are going to use explicitly instead of importing everything using the * wildcard. This makes your import libraries easier to comprehend and maintain.

kewenlok · 2021-09-17T12:45:09Z

src/main/java/duke/Duke.java

+    private static final String COMMAND_EXIT_WORD = "bye";
+    private static final String COMMAND_LIST_WORD = "list";
+    private static final String COMMAND_DONE_WORD = "done";
+    private static final String COMMAND_TODO_WORD = "todo";
+    private static final String COMMAND_DEADLINE_WORD = "deadline";
+    private static final String COMMAND_EVENT_WORD = "event";


Would it be better if you name your constants with the command words grouped at the front? For example, COMMAND_WORD_EXIT.

kewenlok · 2021-09-17T12:48:29Z

src/main/java/duke/Duke.java

+        while (!inputLine.equals(COMMAND_EXIT_WORD)) {
+            try {
+                taskCount = executeCommand(tasksList, taskCount, inputLine.trim());
+                inputLine = INPUT_COMMAND.nextLine();
+            } catch (IllegalCommand e) {
+                System.out.println("  OOPS! I'm sorry, but I don't know what that means :(");
+                System.out.println("  I can only execute these commands: ");
+                for (int i = 1; i <= COMMAND_WORDS_LIST.length; i++) {
+                    System.out.println("  " + i + ". " + COMMAND_WORDS_LIST[i - 1]);
+                }
+                inputLine = INPUT_COMMAND.nextLine();
+            } catch (EmptyToDoDescription e) {
+                System.out.println("  OOPS! The description of a todo cannot be empty!");
+                System.out.println("  Please input again with the correct format!");
+                inputLine = INPUT_COMMAND.nextLine();
+            } catch (IllegalDeadlineInput e) {
+                System.out.println("  OOPS! Please input again using this format:!");
+                System.out.println("  'deadline <description> /by <due date>'");
+                inputLine = INPUT_COMMAND.nextLine();
+            } catch (IllegalEventInput e) {
+                System.out.println("  OOPS! Please input again using this format:!");
+                System.out.println("  'event <description> /at <event date>'");
+                inputLine = INPUT_COMMAND.nextLine();
+            } catch (EmptyTaskNumber e) {
+                System.out.println("  OOPS! Please specify the completed task number!");
+                System.out.println("  Example: 'done 1'");
+                inputLine = INPUT_COMMAND.nextLine();
+            } catch (NumberFormatException e) {
+                System.out.println("  OOPS! Please put only integer as the task number!");
+                System.out.println("  Example: 'done 1'");
+                inputLine = INPUT_COMMAND.nextLine();
+            } catch (NullPointerException e) {
+                System.out.println("  OOPS! You must have typed the wrong number. Please type in again correctly!");
+                inputLine = INPUT_COMMAND.nextLine();
+            }


Since you are going to use the line inputLine = INPUT_COMMAND.nextLine() no matter there is an exception caught or not, you could consider putting a finally statement at the end and place the code there. With this, you could avoid repeating the same code for all exceptions.

kewenlok · 2021-09-17T12:49:09Z

src/main/java/duke/Duke.java

+    private static final Scanner INPUT_COMMAND = new Scanner(System.in);
+
+    public static void main(String[] args) {
+        Task[] tasksList = new Task[MAX_TASKS_NUMBER];


Good job removing the magic literals!

kewenlok · 2021-09-17T12:52:09Z

src/main/java/duke/Duke.java

+        }
+    }
+
+    public static int executeCommand(Task[] tasksList, int taskCount, String inputLine) throws IllegalCommand, EmptyToDoDescription, IllegalDeadlineInput, IllegalEventInput, EmptyTaskNumber {


A line length should not be more than 120 characters because it will be harder for other programmers to look at the code. You should wrap a long line to the next line for better readability.

kewenlok · 2021-09-17T12:53:34Z

src/main/java/duke/task/Task.java

+        return isDone;
+    }
+
+    public void setDone(boolean done) {


Should the name of the boolean done be a boolean name instead?

kewenlok · 2021-09-17T12:53:53Z

src/main/java/duke/task/ToDo.java

+        super(description);
+    }
+
+    @Override


Good use of the override statement for each child task class!

Level-8

…h-Level-9

A-JavaDoc

dyahnafisah added 6 commits August 29, 2021 15:51

customize welcome message

5296d43

add a program to greet the user, echo the command, and exit

4080854

create Task class

856fe73

add a method to add tasks to the list

3c0be23

add a method to mark completed tasks

dc262ae

fix the code according to the coding standard

c96e2ce

dyahnafisah changed the title ~~Dyah Ayu Nurun Nafisah iP~~ [Dyah Ayu Nurun Nafisah] iP Sep 4, 2021

dyahnafisah added 9 commits September 5, 2021 01:18

create ToDo class as the extension of Task class

2f6b19d

create Deadline class as the extension of Task class

88f5f62

create Event class as the extension of Task class

181e7a3

update Task class

ed1269b

add methods to create todos, deadlines, and events

a58b496

fix coding standard and code quality

812be1d

create classes to handle specific exceptions

48d780b

update the program to handle some possible errors

6aefef8

divide the classes into 3 packages

2bc6534

kewenlok reviewed Sep 17, 2021

View reviewed changes

dyahnafisah added 13 commits September 28, 2021 20:47

Update method to handle errors

59aa07a

Merge branch 'branch-Level-5'

78dc2b8

Update emptyToDoDescription method

96cac2c

Merge branch 'branch-A-Packages'

104d604

Use Collections to store data

151b4e9

Add a method to delete task

899bae0

Handle error for empty delete task number

f27181d

Create method to read and save file

e9dd4b8

Handle error when directory not found

fcf6127

Merge branch 'branch-Level-6'

535aae3

Merge branch 'branch-Level-7'

31c05af

rename to duke

edd7dc1

Create more classes

3018c01

dyahnafisah added 10 commits September 30, 2021 23:51

Modify Deadline and Event to have LocalDate parameter

e155601

Add a method to find task based on a specific keyword

9848f83

Merge pull request #1 from dyahnafisah/branch-Level-8

f9f2eef

Level-8

Merge branch 'master' of https://github.com/dyahnafisah/ip into branc…

5f6e945

…h-Level-9

Add JavaDoc

53a2e5a

Merge pull request #3 from dyahnafisah/A-JavaDoc

f772fb1

A-JavaDoc

Add more JavaDoc

3d37fda

Add the User Guide

c69cd5f

Delete manifest to add artifact

94b4d6b

Fix some bugs

6a2c795

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dyah Ayu Nurun Nafisah] iP#200

[Dyah Ayu Nurun Nafisah] iP#200
dyahnafisah wants to merge 38 commits intonus-cs2113-AY2122S1:masterfrom
dyahnafisah:master

dyahnafisah commented Sep 4, 2021

Uh oh!

kewenlok left a comment

Uh oh!

kewenlok Sep 17, 2021

Uh oh!

kewenlok Sep 17, 2021

Uh oh!

kewenlok Sep 17, 2021

Uh oh!

kewenlok Sep 17, 2021

Uh oh!

kewenlok Sep 17, 2021

Uh oh!

kewenlok Sep 17, 2021

Uh oh!

kewenlok Sep 17, 2021

Uh oh!

kewenlok Sep 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

dyahnafisah commented Sep 4, 2021

Uh oh!

kewenlok left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants