-
Notifications
You must be signed in to change notification settings - Fork 197
Add new diagnostics module #1004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I'm leaning against landing this right now. It's so much code and it seems like it would be super intrusive as you're typing. That may just be a preference though. I'm still considering it but I need some convincing. |
I’ll configure it locally for my own shell and use it for a while on a daily basis to check if it is worth it and if it can be made less untrusive. |
39fbb6f to
f5c7dec
Compare
|
@fdncred You can test on this branch (with recent Nu-lint binary): cargo run --example lsp_diagnostics --features lsp_diagnostics |
|
@wvhulle Would you like to add the code action feature to |



I am adding adding real-time diagnostics to Nu shell. To be able to show them, I need to add some features to Reedline. The goal is to give real-time feedback about partial Nushell prompts typed by the user.
In combination with
nu-lintthis could be helpful for new users.CTRL+.. Fixes are accepted withENTER.nu-lintbut instead provide a mechanism for external "diagnostic providers" likenu-lintto send diagnostics to Reedline.There is an example in the
examplesfolder:cargo run --example diagnosticsto see how the diagnostics currently look.