refactor: abbrevation expansion trait logic

[casedami]

as discussed in nushell/nushell#18315

renames is_inside_string_literal to should_expand_abbr and adds an AbbrExpandContext parameter so that the client can define AST expansion logic according to the expansion context (ie 'bang expansion' or 'fish-style expansion')

i would say that the existing abbreviation tests are sufficient on the reedline side of things, especially since the main behavior change will come from nushell

[kronberger-droid]

Any blockers for this to merge? Other than a breaking change note (!).
@fdncred @casedami

[fdncred]

Any blockers for this to merge? Other than a breaking change note (!).

No. My only question is if this fixes the nushell issue on it's own or if there is code needed on the nushell side to fix it there.

[casedami]

It needs code on the nushell side to fix, I have a PR ready for that I just haven't submitted it yet.

[fdncred]

ok, thanks. reedline commits are building up so hopefully patching nushell to the latest reedline commit doesn't break anything else.

[kronberger-droid]

ok, thanks. reedline commits are building up so hopefully patching nushell to the latest reedline commit doesn't break anything else.

I think this one is the only one that could really break anything. Everything else is just exposing things in nushell`s config or is non-breaking.
I will try to keep the markdown note updated.

[fdncred]

@kronberger-droid Great! @casedami Ping me when you have your nushell PR up. Thanks for all the help!