tests(painter): wrapper enum to allow tests to write to sink#1098
Merged
kronberger-droid merged 2 commits intoJun 9, 2026
Conversation
Restored from stash for safekeeping on the branch. Not ready for review. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
I think it's probably ok for now but in the future I'd like to have a way of running tests and capturing ansi escapes to ensure that they're correct. It seems like this would prevent that right now. |
Collaborator
Author
|
Hmm, my idea for that would be to add another field with Buffer ( @fdncred |
Contributor
|
I'm ok with this and also adding a Buffer later if we get to it. |
kronberger-droid
added a commit
to kronberger-droid/reedline
that referenced
this pull request
Jun 13, 2026
…ll#1098) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in rensponse to #1078, which had to use a workaround to not leak test output into the terminal.
I solved this using a wrapper enum:
Allowing to either paint to the Terminal or to a Sink, which will be used in tests.
@fdncred @ymcx
What do you think about using this instead of the workaround in #1078?