-
Notifications
You must be signed in to change notification settings - Fork 327
website: Enable CPEx on staging and development branches #4056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@g0at1 is attempting to deploy a commit to the modsbot's projects Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4056 +/- ##
==========================================
+ Coverage 54.52% 54.82% +0.30%
==========================================
Files 274 276 +2
Lines 6076 6351 +275
Branches 1455 1556 +101
==========================================
+ Hits 3313 3482 +169
- Misses 2763 2869 +106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this update. However there's 2 problems that don't quite seem right to me
- Doing this in
featureFlags.ts
doesn't seem right as this no longer becomes a feature flag - This implicitly breaks for production and the change away from a manual feature flag implies that it should be a fixed value
To solve this issue I would propose either of 2 alternatives:
- Move this logic out featureFlags and convert the feature flag to something like "enableCPExForProd"; or
- Create time based system for CPEx (which is difficult but preferred)
If we are keen on option 2 in this case (ie anyone deems the effort to reward ratio is worth to implement this), perhaps, opening a larger issue in place of #4050 and #4051 is better.
Context
Closes #4051. CPEx should be enabled on branches that are not production to facilitate better testing.
Implementation
I added new variable isProduction and use it to enable CPEx on non production branches.
Other Information