Specify identifying columns on nested mutation upserts #2426
Conversation
spawnia
changed the title
| Specify the columns by which to upsert the model. | ||
| This is optional, defaults to the ID or model Key. | ||
| """ | ||
| identifyingColumns: [String!] = [] |
There was a problem hiding this comment.
| identifyingColumns: [String!] = [] | |
| identifyingColumns: [String!] |
|
|
||
| ### Added | ||
|
|
||
| - Add support for identifyingColumns on upserts |
There was a problem hiding this comment.
| - Add support for identifyingColumns on upserts | |
| - Specify identifying columns on nested mutation upserts with `@upsert(identifyingColumns: ["foo", "bar"])` https://github.com/nuwave/lighthouse/pull/2426 |
| /** @var array<string> */ | ||
| protected array $identifyingColumns; |
There was a problem hiding this comment.
| /** @var array<string> */ | |
| protected array $identifyingColumns; | |
| /** @var array<string>|null */ | |
| protected ?array $identifyingColumns; |
| public function __construct(callable $previous, ?array $identifyingColumns) | ||
| { | ||
| $this->previous = $previous; | ||
| $this->identifyingColumns = $identifyingColumns ?? []; |
There was a problem hiding this comment.
| $this->identifyingColumns = $identifyingColumns ?? []; | |
| $this->identifyingColumns = $identifyingColumns; |
| $this->schema | ||
| /** @lang GraphQL */ | ||
| .= ' |
There was a problem hiding this comment.
| $this->schema | |
| /** @lang GraphQL */ | |
| .= ' | |
| $this->schema .= /** @lang GraphQL */ ' |
| $this->graphQL( | ||
| /** @lang GraphQL */ | ||
| ' |
There was a problem hiding this comment.
| $this->graphQL( | |
| /** @lang GraphQL */ | |
| ' | |
| $this->graphQL(/** @lang GraphQL */ ' |
| $this->graphQL( | ||
| /** @lang GraphQL */ | ||
| ' |
There was a problem hiding this comment.
| $this->graphQL( | |
| /** @lang GraphQL */ | |
| ' | |
| $this->graphQL(/** @lang GraphQL */ ' |
|
|
||
| public function testDirectUpsertByIdentifyingColumns(): void | ||
| { | ||
| $company = factory(Company::class)->create(['id' => 1]); |
There was a problem hiding this comment.
| id: ID! | ||
| email: String! | ||
| name: String! | ||
| company_id: ID! |
There was a problem hiding this comment.
No raw foreign keys in GraphQL, not even as a test case. Often, those test cases serve as an example, so I don't want them to implement anti-patterns.
|
Thanks for the review @spawnia. Sorry I've been a bit quiet on this, recently had our first child so haven't had any free time 🙃 I've been giving the solution a bit more thought, I think supporting nested relationship upsert logic is a must, so I'll try and tackle that when I come to making the suggest changes. I've also been considering my own use case again, where more complex upsert logic was required, and I think a cleaner solution to this might be to permit the specifying of a custom query class that would receive the input params in place of the package's query logic. I may have a go at this in a new fork later. |
3 participants
Changes
Adds optional identifyingColumns arg to upsert directive
Breaking changes
None