test#758
Closed
debjit-hyland wants to merge 37 commits into
Closed
Conversation
Ecosystems: - Maven - GitHub Actions
Bumps the version-updates group with 13 updates: | Package | From | To | | --- | --- | --- | | [io.dropwizard.metrics:metrics-core](https://github.com/dropwizard/metrics) | `4.1.17` | `4.1.36` | | [com.google.protobuf:protobuf-java](https://github.com/protocolbuffers/protobuf) | `4.29.3` | `4.29.5` | | [io.grpc:grpc-auth](https://github.com/grpc/grpc-java) | `1.64.0` | `1.64.2` | | [io.grpc:grpc-core](https://github.com/grpc/grpc-java) | `1.64.0` | `1.64.2` | | [io.grpc:grpc-netty-shaded](https://github.com/grpc/grpc-java) | `1.64.0` | `1.64.2` | | [io.grpc:grpc-stub](https://github.com/grpc/grpc-java) | `1.64.0` | `1.64.2` | | [io.grpc:grpc-grpclb](https://github.com/grpc/grpc-java) | `1.64.0` | `1.64.2` | | [io.grpc:grpc-alts](https://github.com/grpc/grpc-java) | `1.64.0` | `1.64.2` | | [io.grpc:grpc-api](https://github.com/grpc/grpc-java) | `1.64.0` | `1.64.2` | | [io.grpc:grpc-context](https://github.com/grpc/grpc-java) | `1.64.0` | `1.64.2` | | [io.grpc:grpc-protobuf](https://github.com/grpc/grpc-java) | `1.64.0` | `1.64.2` | | [io.grpc:grpc-protobuf-lite](https://github.com/grpc/grpc-java) | `1.64.0` | `1.64.2` | | [kr.motd.maven:os-maven-plugin](https://github.com/trustin/os-maven-plugin) | `1.7.0` | `1.7.1` | Updates `io.dropwizard.metrics:metrics-core` from 4.1.17 to 4.1.36 - [Release notes](https://github.com/dropwizard/metrics/releases) - [Commits](dropwizard/metrics@v4.1.17...v4.1.36) Updates `com.google.protobuf:protobuf-java` from 4.29.3 to 4.29.5 - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl) - [Commits](https://github.com/protocolbuffers/protobuf/commits) Updates `io.grpc:grpc-auth` from 1.64.0 to 1.64.2 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](grpc/grpc-java@v1.64.0...v1.64.2) Updates `io.grpc:grpc-core` from 1.64.0 to 1.64.2 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](grpc/grpc-java@v1.64.0...v1.64.2) Updates `io.grpc:grpc-netty-shaded` from 1.64.0 to 1.64.2 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](grpc/grpc-java@v1.64.0...v1.64.2) Updates `io.grpc:grpc-stub` from 1.64.0 to 1.64.2 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](grpc/grpc-java@v1.64.0...v1.64.2) Updates `io.grpc:grpc-grpclb` from 1.64.0 to 1.64.2 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](grpc/grpc-java@v1.64.0...v1.64.2) Updates `io.grpc:grpc-alts` from 1.64.0 to 1.64.2 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](grpc/grpc-java@v1.64.0...v1.64.2) Updates `io.grpc:grpc-api` from 1.64.0 to 1.64.2 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](grpc/grpc-java@v1.64.0...v1.64.2) Updates `io.grpc:grpc-context` from 1.64.0 to 1.64.2 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](grpc/grpc-java@v1.64.0...v1.64.2) Updates `io.grpc:grpc-protobuf` from 1.64.0 to 1.64.2 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](grpc/grpc-java@v1.64.0...v1.64.2) Updates `io.grpc:grpc-protobuf-lite` from 1.64.0 to 1.64.2 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](grpc/grpc-java@v1.64.0...v1.64.2) Updates `io.grpc:grpc-core` from 1.64.0 to 1.64.2 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](grpc/grpc-java@v1.64.0...v1.64.2) Updates `io.grpc:grpc-netty-shaded` from 1.64.0 to 1.64.2 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](grpc/grpc-java@v1.64.0...v1.64.2) Updates `io.grpc:grpc-stub` from 1.64.0 to 1.64.2 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](grpc/grpc-java@v1.64.0...v1.64.2) Updates `io.grpc:grpc-grpclb` from 1.64.0 to 1.64.2 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](grpc/grpc-java@v1.64.0...v1.64.2) Updates `io.grpc:grpc-alts` from 1.64.0 to 1.64.2 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](grpc/grpc-java@v1.64.0...v1.64.2) Updates `io.grpc:grpc-api` from 1.64.0 to 1.64.2 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](grpc/grpc-java@v1.64.0...v1.64.2) Updates `io.grpc:grpc-context` from 1.64.0 to 1.64.2 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](grpc/grpc-java@v1.64.0...v1.64.2) Updates `io.grpc:grpc-protobuf` from 1.64.0 to 1.64.2 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](grpc/grpc-java@v1.64.0...v1.64.2) Updates `io.grpc:grpc-protobuf-lite` from 1.64.0 to 1.64.2 - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](grpc/grpc-java@v1.64.0...v1.64.2) Updates `kr.motd.maven:os-maven-plugin` from 1.7.0 to 1.7.1 - [Release notes](https://github.com/trustin/os-maven-plugin/releases) - [Commits](trustin/os-maven-plugin@os-maven-plugin-1.7.0...os-maven-plugin-1.7.1) --- updated-dependencies: - dependency-name: io.dropwizard.metrics:metrics-core dependency-version: 4.1.36 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: version-updates - dependency-name: com.google.protobuf:protobuf-java dependency-version: 4.29.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: version-updates - dependency-name: io.grpc:grpc-auth dependency-version: 1.64.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: version-updates - dependency-name: io.grpc:grpc-core dependency-version: 1.64.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: version-updates - dependency-name: io.grpc:grpc-netty-shaded dependency-version: 1.64.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: version-updates - dependency-name: io.grpc:grpc-stub dependency-version: 1.64.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: version-updates - dependency-name: io.grpc:grpc-grpclb dependency-version: 1.64.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: version-updates - dependency-name: io.grpc:grpc-alts dependency-version: 1.64.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: version-updates - dependency-name: io.grpc:grpc-api dependency-version: 1.64.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: version-updates - dependency-name: io.grpc:grpc-context dependency-version: 1.64.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: version-updates - dependency-name: io.grpc:grpc-protobuf dependency-version: 1.64.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: version-updates - dependency-name: io.grpc:grpc-protobuf-lite dependency-version: 1.64.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: version-updates - dependency-name: io.grpc:grpc-core dependency-version: 1.64.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: version-updates - dependency-name: io.grpc:grpc-netty-shaded dependency-version: 1.64.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: version-updates - dependency-name: io.grpc:grpc-stub dependency-version: 1.64.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: version-updates - dependency-name: io.grpc:grpc-grpclb dependency-version: 1.64.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: version-updates - dependency-name: io.grpc:grpc-alts dependency-version: 1.64.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: version-updates - dependency-name: io.grpc:grpc-api dependency-version: 1.64.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: version-updates - dependency-name: io.grpc:grpc-context dependency-version: 1.64.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: version-updates - dependency-name: io.grpc:grpc-protobuf dependency-version: 1.64.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: version-updates - dependency-name: io.grpc:grpc-protobuf-lite dependency-version: 1.64.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: version-updates - dependency-name: kr.motd.maven:os-maven-plugin dependency-version: 1.7.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: version-updates ... Signed-off-by: dependabot[bot] <support@github.com>
This should fix Dependabot version update jobs timing out, trying to fetch a lot of (old) artifacts from multiple repositories. Also, private registries for Dependabot shouldn't be needed, relying on the organization-level private registry: https://packages.nuxeo.com/repository/maven-internal-build/ with "Replaces base" enabled.
In fact, this repository is still needed to fetch old artifacts.
Thus, we need to configure it as a private registry in the Dependabot configuration. Otherwise, the Dependabot version update jobs are unable to authenticate to this registry, complaining with:
```
private_source_authentication_failure {source: "https://packages.nuxeo.com/repository/maven-internal"}
```
Yet, we cannot remove the `maven-internal` repository. It is still needed for the parent POM of `org.nuxeo.ai:nuxeo-jwt-authenticator-core`.
Though the `org.nuxeo.*` dependencies are inherited from the `nuxeo-parent` POM and don't have a version defined, Dependabot tries to fetch them. This leads to version update jobs timing out, because of the big number of old 11.x.y artifacts.
Bumps [io.grpc:grpc-netty-shaded](https://github.com/grpc/grpc-java) from 1.64.0 to 1.75.0. - [Release notes](https://github.com/grpc/grpc-java/releases) - [Commits](grpc/grpc-java@v1.64.0...v1.75.0) --- updated-dependencies: - dependency-name: io.grpc:grpc-netty-shaded dependency-version: 1.75.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Made with ❤️️ by updatecli
Made with ❤️️ by updatecli
Bumps the version-updates group with 1 update: [com.google.protobuf:protobuf-java](https://github.com/protocolbuffers/protobuf). Updates `com.google.protobuf:protobuf-java` from 4.29.5 to 4.29.6 - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Commits](https://github.com/protocolbuffers/protobuf/commits) --- updated-dependencies: - dependency-name: com.google.protobuf:protobuf-java dependency-version: 4.29.6 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: version-updates ... Signed-off-by: dependabot[bot] <support@github.com>
…ty module during image quality check. - Fix 400 error from Sightengine API during image quality check in nuxeo-ai-image-quality module - Update nuxeo-jwt-authenticator dependency to version 2.0.0
Made with ❤️️ by updatecli
Made with ❤️️ by updatecli
Made with ❤️️ by updatecli
Made with ❤️️ by updatecli
Made with ❤️️ by updatecli
|
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s dependency/repository configuration and CI automation (Dependabot + bot auto-merge), bumps the overall version line to 4.0.4-SNAPSHOT, and includes fixes/improvements for the Sightengine image-quality integration.
Changes:
- Bump
nuxeo-parentand multiple dependency versions; align Maven repositories on LTS endpoints and simplify repo lists. - Add/adjust GitHub automation: Dependabot configuration, bot auto-merge reusable workflow, scheduled nuxeo-parent bump workflow; update Docker preview build to use
gh-build-tools. - Fix Sightengine integration details (model name
faces, UTF-8 multipart text parts) and extend image-quality POJOs.
Reviewed changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates the version support matrix for 4.x versions. |
| pom.xml | Bumps parent/version and dependency versions; adjusts repositories/pluginRepositories. |
| nuxeo-ai-web-ui/pom.xml | Updates parent version to 4.0.4-SNAPSHOT. |
| nuxeo-ai-similar-content/pom.xml | Updates parent version to 4.0.4-SNAPSHOT. |
| nuxeo-ai-pipes/pom.xml | Updates parent version to 4.0.4-SNAPSHOT. |
| nuxeo-ai-model/pom.xml | Updates parent version to 4.0.4-SNAPSHOT. |
| nuxeo-ai-internal/pom.xml | Updates parent version to 4.0.4-SNAPSHOT. |
| nuxeo-ai-core/pom.xml | Updates parent version and bumps os-maven-plugin. |
| nuxeo-ai-core-package/pom.xml | Updates parent version to 4.0.4-SNAPSHOT. |
| nuxeo-ai-config/pom.xml | Updates parent version to 4.0.4-SNAPSHOT. |
| docker/skaffold.yaml | Removes legacy Skaffold config. |
| docker/nuxeo-private.repo | Removes legacy yum repo file used by the old Docker build. |
| docker/log4j2.xml | Removes legacy Docker Log4j configuration. |
| docker/Dockerfile | Removes legacy Dockerfile in favor of reusable build tooling. |
| charts/utests/Chart.yaml | Bumps Helm chart version to 4.0.4-SNAPSHOT. |
| charts/preview/Chart.yaml | Bumps Helm chart version to 4.0.4-SNAPSHOT. |
| addons/pom.xml | Updates parent version to 4.0.4-SNAPSHOT. |
| addons/nuxeo-ai-image-quality-package/.../ai-image-quality-config.xml.nxftl | Fixes Sightengine model name to faces and documents the requirement. |
| addons/nuxeo-ai-image-quality-package/pom.xml | Updates parent version to 4.0.4-SNAPSHOT. |
| addons/nuxeo-ai-image-quality-core/.../Offensive.java | Expands offensive content POJO fields and JSON mapping. |
| addons/nuxeo-ai-image-quality-core/.../ImageProperties.java | Adds JSON-mapped fields for weapon/drugs subcategories. |
| addons/nuxeo-ai-image-quality-core/.../Hsv.java | Introduces an HSV value object to model HSV data safely. |
| addons/nuxeo-ai-image-quality-core/.../Color.java | Refactors HSV handling to use the new HSV value object. |
| addons/nuxeo-ai-image-quality-core/.../ImageQualityEnrichmentProvider.java | Forces UTF-8 for multipart text fields sent to Sightengine. |
| addons/nuxeo-ai-image-quality-core/pom.xml | Updates parent version to 4.0.4-SNAPSHOT. |
| addons/nuxeo-ai-gcp-package/pom.xml | Updates parent version to 4.0.4-SNAPSHOT. |
| addons/nuxeo-ai-gcp-core/pom.xml | Updates parent version to 4.0.4-SNAPSHOT. |
| addons/nuxeo-ai-aws-package/pom.xml | Updates parent version to 4.0.4-SNAPSHOT. |
| addons/nuxeo-ai-aws-core/pom.xml | Updates parent version to 4.0.4-SNAPSHOT. |
| .github/workflows/pipeline_release.yml | Removes now-unused Maven server credentials from CI settings.xml. |
| .github/workflows/build_and_test.yml | Removes now-unused Maven server credentials from CI settings.xml. |
| .github/workflows/bot-auto-merge.yml | Adds reusable workflow to auto-merge bot PRs. |
| .github/workflows/_default_branch-update-nuxeo-parent.yml | Adds scheduled Updatecli workflow to bump nuxeo-parent on LTS branches. |
| .github/dependabot.yaml | Enables Dependabot version updates for Maven and GitHub Actions across branches. |
| .github/actions/docker-build-preview/action.yml | Switches preview Docker build to gh-build-tools reusable action and prepares docker/ context. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+95
to
106
| @JsonProperty("prob") | ||
| public Float getProb() { | ||
| return prob; | ||
| } | ||
|
|
||
| public void setProb(float prob) { | ||
| /** | ||
| * Sets the offensive probability from a boxed Float. | ||
| */ | ||
| @JsonProperty("prob") | ||
| public void setProb(Float prob) { | ||
| this.prob = prob; | ||
| } |
| | 3.0.x | 11.1-SNAPSHOT | | ||
| | 4.0.0 | 2023.0 | | ||
| | 4.0.1 | 2023.0 | | ||
| | 4.0.2 | 2023.31 | |
Comment on lines
+51
to
+56
| - name: Build Nuxeo image | ||
| uses: nuxeo/gh-build-tools/.github/actions/nuxeo-docker-build@v0.8.0 | ||
| with: | ||
| base-registry-username: ${{ inputs.docker-username }} | ||
| base-registry-password: ${{ inputs.docker-password }} | ||
| nuxeo-connect-modules: nuxeo-web-ui replace-administrator-user-1.0.0 |
Comment on lines
+122
to
126
| private static final ContentType UTF8_TEXT_PLAIN = ContentType.create(ContentType.TEXT_PLAIN.getMimeType(), StandardCharsets.UTF_8); | ||
|
|
||
| @Override | ||
| public void init(EnrichmentDescriptor descriptor) { | ||
| super.init(descriptor); |
Comment on lines
9
to
13
| <groupId>org.nuxeo.ai</groupId> | ||
| <artifactId>ai-core-parent</artifactId> | ||
| <version>4.0.3-SNAPSHOT</version> | ||
| <version>4.0.4-SNAPSHOT</version> | ||
| <name>Ai core parent</name> | ||
| <description>Nuxeo AI functionality</description> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



test