WEBUI-2038: Remove stale tmp@0.2.3 from root lockfile (GHSA-52f5-9888-hmc6)#3173
Merged
madhurkulshrestha-hyland merged 1 commit intoMay 21, 2026
Conversation
Removed the packages/nuxeo-web-ui-ftest/node_modules/tmp entry that was pinned to vulnerable 0.2.3. With this entry gone, npm correctly hoists tmp@0.2.5 from root node_modules (via the override). The lockfile is stable across npm install cycles — the entry does not reappear. Eliminates Dependabot alert GHSA-52f5-9888-hmc6 (tmp symlink write).
madhurkulshrestha-hyland
requested review from
AnilKumarVanga,
Nishant0928 and
Copilot
and removed request for
a team
|
madhurkulshrestha-hyland
deleted the
task-webui-2038-regen-root-lockfile-lts2025
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the stale
packages/nuxeo-web-ui-ftest/node_modules/tmpentry from the rootpackage-lock.jsonto eliminate the Dependabot alert for GHSA-52f5-9888-hmc6 (tmp arbitrary file/directory write via symlink).Problem
The root lockfile had a nested entry pinning
tmp@0.2.3for the ftest workspace sub-tree. Despite the"tmp": "^0.2.4"override in both root and ftestpackage.json, npm was not updating this lockfile entry (npm limitation withfile:linked packages).Fix
Removed the 10-line stale entry entirely. With it gone, npm correctly hoists
tmp@0.2.5from rootnode_modules/(via the override).Verified stable: After removal, subsequent
rm -rf node_modules && npm installcycles do NOT recreate the ftest sub-tree entry — npm continues to use the hoisted 0.2.5.Result