Skip to content

WEBUI-1683:Vocabulary Filter[LTS-2025]#3176

Open
vaibhavagarwal4-lab wants to merge 9 commits into
lts-2025from
fix-WEBUI-1683-vocabulary-filter-lts2025
Open

WEBUI-1683:Vocabulary Filter[LTS-2025]#3176
vaibhavagarwal4-lab wants to merge 9 commits into
lts-2025from
fix-WEBUI-1683-vocabulary-filter-lts2025

Conversation

@vaibhavagarwal4-lab
Copy link
Copy Markdown
Contributor

@vaibhavagarwal4-lab vaibhavagarwal4-lab requested a review from a team as a code owner May 21, 2026 20:36
@vaibhavagarwal4-lab vaibhavagarwal4-lab requested review from Nishant0928, Copilot and swarnadipa-dev and removed request for a team May 21, 2026 20:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements column-based filtering for the Vocabulary Management table so administrators can quickly narrow down directory entries, while preserving an “empty when filtered” table state instead of hiding the table.

Changes:

  • Adds per-column filter inputs in the nuxeo-data-table header and client-side filtering logic (_filters, _allEntries, _applyFilters, _onAnyInput).
  • Updates table visibility logic to keep the table visible when filters are active but yield zero matches.
  • Updates/extends unit tests to cover the new filtering and formatting behaviors.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
elements/directory/nuxeo-vocabulary-management.js Adds the UI (header inputs) and the underlying filtering state/logic to support column filters in the vocabulary entries table.
test/nuxeo-vocabulary-management.test.js Updates existing tests and adds coverage for the new filter/formatting behavior and event delegation.

Comment thread elements/directory/nuxeo-vocabulary-management.js
Comment thread elements/directory/nuxeo-vocabulary-management.js Outdated
@vaibhavagarwal4-lab
Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

…cabulary-filter-lts2025

# Conflicts:
#	test/nuxeo-vocabulary-management.test.js

Co-authored-by: vaibhavagarwal4-lab <221356955+vaibhavagarwal4-lab@users.noreply.github.com>
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ vaibhavagarwal4-lab
❌ Copilot
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown
Contributor

Copilot AI commented May 24, 2026

@copilot resolve the merge conflicts in this pull request

Resolved the merge conflict and pushed the merge commit in a47dc02. The branch is mergeable again; the only manual conflict was in test/nuxeo-vocabulary-management.test.js, and I preserved the existing test suite while removing the conflict markers.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • packages.nuxeo.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/_temp/ghcca-node/node/bin/npm install (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants