Migrate preview workflow to docker-internal registry#3182
Open
madhurkulshrestha-hyland wants to merge 1 commit into
Open
Migrate preview workflow to docker-internal registry#3182madhurkulshrestha-hyland wants to merge 1 commit into
madhurkulshrestha-hyland wants to merge 1 commit into
Conversation
madhurkulshrestha-hyland
requested review from
Nishant0928,
Copilot and
swarnadipa-dev
and removed request for
a team
madhurkulshrestha-hyland
added
the
preview
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the “preview” GitHub Actions workflow away from GCP Artifact Registry/GKE and toward publishing preview images into the internal Docker registry (docker-internal.packages.nuxeo.com) as part of the EKS migration.
Changes:
- Replaces GCP registry/image env vars with
REGISTRY+REPOSITORYtargetingdocker-internal.packages.nuxeo.com/nuxeo/nuxeo-web-ui. - Switches Docker authentication from GKE service-account JSON key to
NUXEO_DOCKER_USERNAME/NUXEO_DOCKER_TOKEN. - Removes the Helm/GKE deployment steps and updates the PR comment to publish the built image reference.
madhurkulshrestha-hyland
force-pushed
the
migrate-preview-to-docker-internal-maintenance
branch
from
e05e7c3 to
3c2d31a
Compare
Contributor
Author
|
Addressed review comments:
Note: The |
Replace GCP Artifact Registry and GKE deployment with docker-internal.packages.nuxeo.com for the EKS migration. Changes: - Update Docker registry to docker-internal.packages.nuxeo.com - Use NUXEO_DOCKER_USERNAME/NUXEO_DOCKER_TOKEN for auth - Remove GKE cluster/zone configuration - Remove Google Cloud auth and GKE credentials steps - Remove helm-based preview deployment - Remove PREVIEW_NAMESPACE (no longer needed) - Remove clean.yaml (GKE namespace cleanup no longer applicable) - Rename output from 'url' to 'image' to reflect it is a Docker image ref
madhurkulshrestha-hyland
force-pushed
the
migrate-preview-to-docker-internal-maintenance
branch
from
3c2d31a to
003265b
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate the preview workflow from GCP Artifact Registry + GKE deployment to publishing images to
docker-internal.packages.nuxeo.comfor the EKS migration.Changes
us-east1-docker.pkg.dev→docker-internal.packages.nuxeo.comnuxeo/nuxeo-web-ui_json_key/GKE_SA_KEY→NUXEO_DOCKER_USERNAME/NUXEO_DOCKER_TOKENPREVIEW_NAMESPACEdocker-internal.packages.nuxeo.com/nuxeo/nuxeo-web-ui/server:<VERSION>docker-internal.packages.nuxeo.com/nuxeo/nuxeo-web-ui:<VERSION>Required secrets
NUXEO_DOCKER_USERNAMENUXEO_DOCKER_TOKENNPM_PACKAGES_TOKEN(unchanged)References