WEBUI-810: Vocabulary Actions[LTS-2023]#3187
Open
vaibhavagarwal4-lab wants to merge 8 commits into
Open
Conversation
vaibhavagarwal4-lab
requested review from
madhurkulshrestha-hyland and
naveen-konda
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for read-only vocabularies in the Vocabulary Management UI (WEBUI-810), ensuring server-declared read-only directories cannot be modified from the Web UI.
Changes:
- Hide “Add entry”, “Edit”, and “Delete” actions when the selected vocabulary is marked
readOnly. - Add a computed
_isReadOnlyproperty (based on selected vocabulary + server-providedreadOnlyflag) and guard mutating handlers (_createEntry,_save,_editEntry,_deleteEntry). - Extend unit tests to cover
_computeReadOnlyand verify the read-only guards.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| elements/directory/nuxeo-vocabulary-management.js | Adds _isReadOnly computed state, hides UI actions for read-only vocabularies, and blocks mutating operations via early-return guards. |
| test/nuxeo-vocabulary-management.test.js | Adds tests for _computeReadOnly and for no-op behavior of create/save/delete when a read-only vocabulary is selected. |
vaibhavagarwal4-lab
changed the title
|
Comment on lines
+97
to
+99
| paper-button[disabled] { | ||
| opacity: 0.95; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://hyland.atlassian.net/browse/WEBUI-810