WEBUI-157: Fix vocabulary management when the entry key starts with @ [LTS-2023]#3193
Open
AnilKumarVanga wants to merge 5 commits into
Conversation
AnilKumarVanga
requested review from
naveen-konda and
swarnadipa-dev
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses WEBUI-157 by ensuring directory/vocabulary entry paths are correctly URL-encoded (notably when an entry id starts with @), preventing failures in vocabulary management CRUD operations.
Changes:
- Add
_encodePathSegment()to safely encode individual directory/id path segments without double-encoding. - Route create/update/delete requests through a new
_executeDirectoryRequest()helper to avoid path re-encoding issues. - Expand unit tests to cover encoding behavior and CRUD path construction (including
@-prefixed ids).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/nuxeo-vocabulary-management.test.js | Adds tests for path-segment encoding and verifies encoded paths are used for save/delete flows and request execution. |
| elements/directory/nuxeo-vocabulary-management.js | Encodes directory/id segments when building directory entry URLs and introduces a helper to execute requests without re-encoding the already-encoded path. |
AnilKumarVanga
force-pushed
the
WEBUI-157-fix-vocabulary-management-when-the-entry-key-starts-with
branch
from
7feb472 to
5d899c9
Compare
…starts-with' of https://github.com/nuxeo/nuxeo-web-ui into WEBUI-157-fix-vocabulary-management-when-the-entry-key-starts-with
|
madhurkulshrestha-hyland
approved these changes
May 27, 2026
swarnadipa-dev
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://hyland.atlassian.net/browse/WEBUI-157