-
Notifications
You must be signed in to change notification settings - Fork 66
WEBUI-1736: fix screen reader redundant and adjacent links [LTS-2025] #3251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
swarnadipa-dev
wants to merge
5
commits into
lts-2025
Choose a base branch
from
fix-WEBUI-1736-screen-reader-redundant-text-lts-2025
base: lts-2025
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+740
−43
Open
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0a13dcd
WEBUI-1736: fix screen reader redundant and adjacent links
swarnadipa-dev 4f15c53
test(WEBUI-1736): add/update unit tests for WCAG H2 thumbnail+link ch…
swarnadipa-dev 9efac82
test(WEBUI-1736): address Copilot review comments
swarnadipa-dev 9f64eb6
WEBUI-1736: fix ellipsis width and _navigateLink data-index
swarnadipa-dev 2a19b32
WEBUI-1736: fix screen reader announcing actions on outer card focus
swarnadipa-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| /** | ||
| @license | ||
| ©2023 Hyland Software, Inc. and its affiliates. All rights reserved. | ||
| All Hyland product names are registered or unregistered trademarks of Hyland Software, Inc. or its affiliates. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| /** | ||
| * Tests for WEBUI-1736 (nuxeo-assets-search-results): | ||
| * | ||
| * The fix applies WCAG H2 technique: `<nuxeo-document-thumbnail alt="">` is | ||
| * combined with the document title text inside a single `<a>` element so that | ||
| * screen readers do not announce the link twice. | ||
| */ | ||
|
|
||
| /** Recursively collect all elements matching selector, descending into <template> content. */ | ||
| function queryAllDeep(root, selector) { | ||
| const results = []; | ||
| root.querySelectorAll(selector).forEach((el) => results.push(el)); | ||
| root.querySelectorAll('template').forEach((t) => { | ||
| results.push(...queryAllDeep(t.content, selector)); | ||
| }); | ||
| return results; | ||
| } | ||
|
|
||
| let tmpl; | ||
|
|
||
| suiteSetup(async () => { | ||
| const url = '/elements/search/assets/nuxeo-assets-search-results.html'; | ||
| const selector = 'dom-module#nuxeo-assets-search-results template'; | ||
| const response = await fetch(url); | ||
| expect(response.ok, `Failed to fetch ${url}: ${response.status} ${response.statusText}`).to.be.true; | ||
| const text = await response.text(); | ||
| const doc = new DOMParser().parseFromString(text, 'text/html'); | ||
| tmpl = doc.querySelector(selector); | ||
| expect(tmpl, `Template not found for selector "${selector}" in ${url}`).to.not.be.null; | ||
| }); | ||
|
|
||
| suite('nuxeo-assets-search-results', () => { | ||
| suite('WCAG H2: thumbnail combined with title text in one link', () => { | ||
| test('nuxeo-document-thumbnail is present in the template', () => { | ||
| const thumbnails = queryAllDeep(tmpl.content, 'nuxeo-document-thumbnail'); | ||
| expect(thumbnails.length).to.be.greaterThan(0, 'should have at least one nuxeo-document-thumbnail'); | ||
| }); | ||
|
|
||
| test('every nuxeo-document-thumbnail has alt="" (decorative image)', () => { | ||
| const thumbnails = queryAllDeep(tmpl.content, 'nuxeo-document-thumbnail'); | ||
| thumbnails.forEach((thumb) => { | ||
| expect(thumb.getAttribute('alt')).to.equal( | ||
| '', | ||
| `thumbnail should have alt="" but got "${thumb.getAttribute('alt')}"`, | ||
| ); | ||
| }); | ||
| }); | ||
|
|
||
| test('every nuxeo-document-thumbnail is inside an <a> link', () => { | ||
| const thumbnails = queryAllDeep(tmpl.content, 'nuxeo-document-thumbnail'); | ||
| thumbnails.forEach((thumb) => { | ||
| const link = thumb.closest('a'); | ||
| expect(link, 'nuxeo-document-thumbnail should be a descendant of an <a> element').to.exist; | ||
| }); | ||
| }); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.