WEBUI-2092:Fix Saved Search failing to Clear true value on nuxeo-directory-suggestion tied to Boolean property [LTS-2025]#3257
Open
Conversation
AnilKumarVanga
requested review from
madhurkulshrestha-hyland and
swarnadipa-dev
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the Reset behavior of nuxeo-search-form so that resetting the form always clears current filters/values, even when a saved search is currently selected—addressing the “saved search can’t clear boolean true value” scenario described by WEBUI-2092.
Changes:
- Simplifies
nuxeo-search-form’s_reset()to always delegate to_clear(). - Updates unit tests to reflect the new reset behavior for saved searches.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
elements/search/nuxeo-search-form.js |
Makes _reset() always call _clear() (removes saved-search reload branch). |
test/nuxeo-search-form.test.js |
Updates reset-related test expectations to match the new “always clear” reset behavior. |
|
AnilKumarVanga
changed the title
AnilKumarVanga
force-pushed
the
WEBUI-2092-fix-saved-search-failing-to-clear-true-value-on-nuxeo-directory-suggestion-tied-to-boolean-property-lts-2025
branch
from
6a66f21 to
5ee851b
Compare
…ctory-suggestion tied to Boolean property
AnilKumarVanga
force-pushed
the
WEBUI-2092-fix-saved-search-failing-to-clear-true-value-on-nuxeo-directory-suggestion-tied-to-boolean-property-lts-2025
branch
from
5ee851b to
01cd23f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://hyland.atlassian.net/browse/WEBUI-2092