Reset result when unmounted #202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baroshem
reviewed
Jul 18, 2024
Comment on lines
+42
to
+44
| onUnmounted(() => { | ||
| result.value = undefined; | ||
| }); |
There was a problem hiding this comment.
Hey, what about instead to provide a reset function so that the user can trigger this reset function when he needs? :)
It can even be the same (on onUnmounted hook) but it will be done by the consumer of the library instead of the library itself :)
There was a problem hiding this comment.
Actually that makes more sense! :)
There was a problem hiding this comment.
Great, could you refactor your code to this change? Then I could merge, test and release a new version with it to unblock you :)
There was a problem hiding this comment.
@Baroshem Can you continue here maybe? I dont have the time unfortunately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
#201
Checklist: