fix: on-demand chromium for dev / prerender #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #134
The higher-level issue is that we need to make sure chrome is available for rendering screenshots but we don't want to have to have the end-user manually add the
playwrightdependency for development/prerendering. This is a minor DX improvement but one that I was interesting in exploring. (Waiting for all playwright binaries to install is painful)Previously we just always installed chrome to make sure it was available. Instead, we introduce a new chromium binding called 'on-demand' that will install the dependency using npx when chrome is being used.
We also move the separate ways of using chromium to individual bindings, this should allow quicker og image generation as well as we don't need to use hacks around dynamic imports of modules.