Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: on-demand chromium for dev / prerender #150

Merged
merged 2 commits into from
Jan 27, 2024
Merged

Conversation

harlan-zw
Copy link
Collaborator

@harlan-zw harlan-zw commented Jan 27, 2024

Issue: #134

The higher-level issue is that we need to make sure chrome is available for rendering screenshots but we don't want to have to have the end-user manually add the playwright dependency for development/prerendering. This is a minor DX improvement but one that I was interesting in exploring. (Waiting for all playwright binaries to install is painful)

Previously we just always installed chrome to make sure it was available. Instead, we introduce a new chromium binding called 'on-demand' that will install the dependency using npx when chrome is being used.

We also move the separate ways of using chromium to individual bindings, this should allow quicker og image generation as well as we don't need to use hacks around dynamic imports of modules.

@harlan-zw harlan-zw merged commit b57ee3f into main Jan 27, 2024
1 check passed
@harlan-zw harlan-zw deleted the fix/on-demand-chromium branch January 27, 2024 03:15
@harlan-zw harlan-zw mentioned this pull request Jan 27, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant