Skip to content

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

this addresses a performance issue in which all font providers initialise in modules:done, blocking the vite build.

instead, we initiate the font provider setup at the same point, in a non-blocking manner, and wait only when it's required

Copy link

pkg-pr-new bot commented Sep 9, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/fonts@688

commit: d1421b5

Copy link

cloudflare-workers-and-pages bot commented Sep 9, 2025

Deploying fonts with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: d1421b5
Status:Β βœ…Β  Deploy successful!
Preview URL: https://b00d5cc7.fonts-dsw.pages.dev
Branch Preview URL: https://perf-non-blocking.fonts-dsw.pages.dev

View logs

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2025

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 77.31%. Comparing base (e01dc68) to head (d1421b5).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
+ Coverage   76.90%   77.31%   +0.40%     
==========================================
  Files          11       11              
  Lines         576      573       -3     
  Branches      125      127       +2     
==========================================
  Hits          443      443              
+ Misses        127      124       -3     
  Partials        6        6              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danielroe danielroe marked this pull request as ready for review September 9, 2025 20:52
@danielroe danielroe merged commit cdd1262 into main Sep 9, 2025
6 checks passed
@danielroe danielroe deleted the perf/non-blocking branch September 9, 2025 20:55
@github-actions github-actions bot mentioned this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants