fix(adobe): handle provider configuration objects properly #737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
Potentially fixes Adobe font-face declaration generation regression introduced in v0.12.1.
Closes #736
📝 Description
After upgrading from
fontless0.0.2 to 0.1.0, Adobe provider configuration objects were not being properly initialized. When users configured Adobe fonts like:The
resolveProvidersfunction from fontless treated the{ id: [...] }object as the provider itself, rather than recognizing it as configuration to pass to the Adobe provider factory from unifont.🔧 Changes
src/module.tsmodules:donehook to:✅ Testing
🔄 Backward Compatibility
This fix maintains full backward compatibility with:
📸 Before/After
Before (0.12.1):
After (with this fix):
✅ Font-face declarations generated successfully
✅ Adobe fonts load correctly in the application