Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider): add directus (v0) #572

Open
wants to merge 1 commit into
base: v0
Choose a base branch
from

Conversation

shadow81627
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2022

Codecov Report

Merging #572 (231900b) into v0 (d837956) will increase coverage by 0.37%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##               v0     #572      +/-   ##
==========================================
+ Coverage   58.73%   59.11%   +0.37%     
==========================================
  Files          34       35       +1     
  Lines         647      653       +6     
  Branches      218      220       +2     
==========================================
+ Hits          380      386       +6     
  Misses        266      266              
  Partials        1        1              
Impacted Files Coverage Δ
src/provider.ts 74.28% <ø> (ø)
src/runtime/providers/directus.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d837956...231900b. Read the comment docs.

@vanling
Copy link

vanling commented Jul 17, 2022

@shadow81627 Thanks & awesome! let's hope this gets reviewed and merged soon ^^

@melrefaie
Copy link

@pi0

@pi0 pi0 changed the title feat(provider): add directus feat(provider): add directus (v0) Sep 3, 2022
@pi0 pi0 added the v0 label Oct 18, 2022
@genu
Copy link

genu commented Oct 24, 2022

Not sure if this PR just needs to be updated with upstream changes, but in my testing, in order to get transforms to work, I need to JSON.stringify(...) the data, like so:

<template>
      <nuxt-img :src="imageId" width="260" :modifiers="{ transforms: JSON.stringify(imageTransforms) }" />
</template>
const imageTransforms = [['blur', 45]]

That should probably happen inside of the provider?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants