Skip to content

Conversation

J-Michalek
Copy link
Contributor

πŸ”— Linked issue

Resolves: #4718

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I added a new props showButtons that add the option to hide the buttons.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@J-Michalek
Copy link
Contributor Author

The wording in the docs could be improved and also I'm not sure about the prop name some alternatives would be hideButtons: boolean, buttons: boolean or perhaps integrate it into the increment and decrement props to allow false to be passed in and hide the button...

Copy link

pkg-pr-new bot commented Aug 22, 2025

npm i https://pkg.pr.new/@nuxt/ui@4805

commit: e7c04f1

@benjamincanac benjamincanac added the v3 #1289 label Aug 27, 2025
@J-Michalek J-Michalek changed the base branch from v3 to v4 October 13, 2025 04:46
renovate bot and others added 2 commits October 13, 2025 09:45
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Copy link
Member

@benjamincanac benjamincanac Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to handle boolean | ButtonProps in increment and decrement a v-if="increment !== false" instead? πŸ€”

renovate bot and others added 7 commits October 13, 2025 10:49
@J-Michalek
Copy link
Contributor Author

@benjamincanac I've addressed #4805 (comment)

I am wondering if we could get rid of incrementDisabled and decrementDisabled props in favor of increment.disabled and decrement.disabled, what do you think?

@benjamincanac
Copy link
Member

I agree it would be better but this would cause a breaking change 😬

@J-Michalek J-Michalek changed the title feat(InputNumber): add showButtons prop feat(InputNumber): add option to hide increment/decrement buttons Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v3 #1289 v4 #4488

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[InputNumber] add option to hide increment/decrement buttons

3 participants