-
Notifications
You must be signed in to change notification settings - Fork 901
feat(InputNumber): add option to hide increment/decrement buttons #4805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v4
Are you sure you want to change the base?
Conversation
The accept prop did not work with image/* etc.
This reverts commit 5b75835.
The wording in the docs could be improved and also I'm not sure about the prop name some alternatives would be |
commit: |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be better to handle boolean | ButtonProps
in increment
and decrement
a v-if="increment !== false"
instead? π€
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
The accept prop did not work with image/* etc.
This reverts commit 5b75835.
β¦alek/ui into feat/input-number-buttons
@benjamincanac I've addressed #4805 (comment) I am wondering if we could get rid of |
I agree it would be better but this would cause a breaking change π¬ |
showButtons
prop
π Linked issue
Resolves: #4718
β Type of change
π Description
I added a new props
showButtons
that add the option to hide the buttons.π Checklist