fix(Table): respect enableRowSelection in data-selectable attribute #5611
+61
β1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Resolves #4968
β Type of change
π Description
The
data-selectableattribute on table rows was not respecting therowSelectionOptions.enableRowSelectionoption. WhenenableRowSelectionis defined (e.g., toconditionally disable selection on certain rows), the attribute should reflect whether each individual row can be selected via
row.getCanSelect().Before:
data-selectableonly checked foronSelect,onHover, oronContextmenupropsAfter:
data-selectablefirst checks ifenableRowSelectionis defined, and if so, usesrow.getCanSelect(), otherwise falls back to the original behaviorThis fix ensures that rows with disabled selection get
data-selectable="false".Testing: added tests 'data-selectable attribute with rowSelectionOptions.enableRowSelection' and 'data-selectable attribute fallback behavior' to test that the new behavior and old behavior work correctly.
π Checklist