Conversation
….json (#530) 1. Currently, CMake adds `-L` flags to compiling object files. GCC does not warn about this, but Clang does. Suppress the noise with `-Wno-unused-command-line-argument`. 2. `CMakePresets.json` are relatively recent but allow you to easily kick off a CMake configure/build/test (or combination of all via workflow). Add an initial (opinionated) configuration that offers four options: * gcc-debug * gcc-release * clang-debug * clang-release The advantage here is the end user doesn't have to remember a bunch of flags to pass to CMake. They can just invoke via: `cmake --workflow --preset gcc-debug`. This also offers better IDE integration, particularly in VSCode. Authors: - Will Killian (https://github.com/willkill07) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: #530
Forward-merge branch-25.02 into branch-25.06
* Replace V100 runner with an L4 runner Authors: - Will Killian (https://github.com/willkill07) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: #531
Forward-merge branch-25.02 into branch-25.06
* Removes `MRC_USE_CONDA` since it must always be on. * Cleans up some CMake + build files along the way. * Fixes some minor linting issues in `mrc.code-workspace` This necessary as part of nv-morpheus/Morpheus#2154 Authors: - Will Killian (https://github.com/willkill07) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: #539
* Adopt CUDA 12.8 * Remove unused download_deps script (unrelated to adopting 25.02) Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Will Killian (https://github.com/willkill07) URL: #536
This is #541 but having all commits rebased on `branch-25.06` * `pybind11::error_already_set` now inherits from `std::exception` rather than `std::runtime_error` * Adopt Pybind11 2.12, required for Python 3.12 support * Disable Pybind's ing_ref/dec_ref checking (#542) * Adopt updated version of versioneer, removing the need for `versioneer.py` in the repo. * Work-around for llvm/llvm-project#92948 ref: #543 * Fetch commit history so proper version can be detected for tests Authors: - Will Killian (https://github.com/willkill07) - David Gardner (https://github.com/dagardner-nv) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: #544
Upstream RAPIDS will eventually be removing boa from the default images. Since they are functionally equivalent, let's adapt. Authors: - Will Killian (https://github.com/willkill07) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: #546
* Replace the `DCHECK_LE` in the `ReusableFiberEngineFactory` class with an if/throw. * Update `~EdgeHolder` to `LOG(DFATAL)`. The thinking here is that this error is only of use to MRC developers and not of use to downstream users (Borrowed from PR #434). Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Will Killian (https://github.com/willkill07) URL: #547
dagardner-nv
added
conda-build
Signed-off-by: David Gardner <dagardner@nvidia.com>
willkill07
approved these changes
Jul 22, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
==========================================
- Coverage 73.99% 73.58% -0.41%
==========================================
Files 407 407
Lines 15106 15144 +38
Branches 1198 1204 +6
==========================================
- Hits 11177 11144 -33
- Misses 3929 4000 +71
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
* Python tests depend on `pytest-asyncio` * Fix local CI bug Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Will Killian (https://github.com/willkill07) URL: #552
* Work-around for #554 Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Will Killian (https://github.com/willkill07) URL: #555
github-project-automation
bot
moved this from Review - Approved
to Done
in Morpheus Boards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❄️ Code freeze for
branch-25.06andv25.06releaseWhat does this mean?
Only critical/hotfix level issues should be merged into
branch-25.06until release (merging of this PR).All other development PRs should be retargeted towards the next release branch:
branch-25.10.What is the purpose of this PR?
branch-25.06intomainfor the release