Improve PLY loading robustness and error handling #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hermanye996
commented
Sep 11, 2025
Hermanye996
commented
- Add support for PLY files with only DC components (no higher-order spherical harmonics)
- Initialize higher-order harmonics to zero when only DC components are available
- Add better error logging with full traceback in ply_to_usd.py script
- Improve error messages for unexpected spherical harmonics data structure
- Add support for PLY files with only DC components (no higher-order spherical harmonics) - Initialize higher-order harmonics to zero when only DC components are available - Add better error logging with full traceback in ply_to_usd.py script - Improve error messages for unexpected spherical harmonics data structure
wilsonCernWq
requested changes
Sep 30, 2025
Collaborator
wilsonCernWq
left a comment
wilsonCernWq
left a comment
There was a problem hiding this comment.
Overall makes a lot sense to me! Thank you for your contribution. Only have a small nitpicking comment.
Co-authored-by: Qi Wu <[email protected]>
Contributor
Author
|
@wilsonCernWq Thank you for the review! I've addressed your feedback and made the requested changes. The code has been updated according to your suggestions. Could you please take another look when you have a chance? |
wilsonCernWq
approved these changes
Oct 9, 2025
Collaborator
wilsonCernWq
left a comment
wilsonCernWq
left a comment
There was a problem hiding this comment.
looks good to me, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.