Skip to content

Fix Depth Supervision #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2025
Merged

Fix Depth Supervision #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions threedgut_tracer/include/3dgut/kernels/cuda/models/gaussianParticles.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@ __device__ inline void processHitBwd(
float3 radianceGrad,
float integratedDepth,
float& depth,
float depthGrad) {
float integratedDepthGrad) {
float3 particlePosition;
float3 gscl;
float33 particleRotation;
Expand Down Expand Up @@ -550,11 +550,11 @@ __device__ inline void processHitBwd(
// ===> d_hitT / d_galpha = gdist * prevTrm - residualHitT * prevTrm
// = (gdist - residualHitT) * prevTrm
//
const float galphaRayHitGrd = (gdist - residualHitT) * transmittance * depthGrad;
const float galphaRayHitGrd = (gdist - residualHitT) * transmittance * integratedDepthGrad;
//
// ===> d_hitT / d_gsqdist = weight / (2*gdist)
// ===> d_gsqdist / d_grds = 2 * grds
const float3 grdsRayHitGrd = gsqdist > 0.0f ? ((2 * grds * weight) / (2 * gdist)) * depthGrad : make_float3(0.0f);
const float3 grdsRayHitGrd = gsqdist > 0.0f ? ((2 * grds * weight) / (2 * gdist)) * integratedDepthGrad : make_float3(0.0f);

// ---> grds = gscl * grd * dot(grd, -1 * gro)
//
Expand Down
2 changes: 1 addition & 1 deletion threedgut_tracer/include/3dgut/kernels/cuda/models/shRadiativeGaussianParticles.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,8 +401,8 @@ struct ShRadiativeGaussianVolumetricFeaturesParticles : Params, public ExtParams
reinterpret_cast<const float3&>(featuresBackward),
reinterpret_cast<float3&>(features),
reinterpret_cast<const float3&>(featuresGradient),
hitT,
hitTBackward,
hitT,
hitTGradient);
}

Expand Down