Skip to content

Conversation

@wilsonCernWq
Copy link
Collaborator

No description provided.

@wilsonCernWq wilsonCernWq requested review from nvibd and orperel October 9, 2025 17:15
UINT32_MASK = 0xFFFFFFFF # torch doesn't natively support uint32 so we force the overflow with a mask


SOBOL_DIRECTIONS = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal - but is there an annotation to ignore formatting here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I added # fmt: off and #fmt: on around the section you highlighted!


# Subpixel offset values used by DirectX MSAA (Source: Ray Tracing Gems II)
subpixel_means = dict(
s1 = [[0.5, 0.5]],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too - can we please ignore formatting?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, I added # fmt: off and #fmt: on around the section you highlighted!

@wilsonCernWq wilsonCernWq merged commit f530c88 into main Oct 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants