Fix issue 65 - #102
Open
sruggier wants to merge 2 commits into
Open
Conversation
This mainly fixes lint warnings and potentially improves behaviour in a corner case.
Previously, it was only possible to import the output into older versions of COLMAP, because newer versions are stricter about consistency between 3D and 2D point definitions. This also affected tools that were parsing input using PyCOLMAP, which uses the same implementation. This commit improves conformance in the following ways: * invalid 2D point references are no longer emitted with the 3D points * the emitted image paths are relative to the image directory * the text files are placed under a sparse/0 subdirectory A note is also added to explain how to re-enable rendering of the emitted points in COLMAP, now that they no longer have a minimum track length of 3. These changes make it possible to import the data into the latest versions of COLMAP, as well as other tools that expect a similar format, like gsplat. Fixes nv-tlabs#65.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, it was only possible to import the output into older
versions of COLMAP, because newer versions are stricter about
consistency between 3D and 2D point definitions. This also affected
tools that were parsing input using PyCOLMAP, which uses the same
implementation.
This commit improves conformance in the following ways:
A note is also added to explain how to re-enable rendering of the
emitted points in COLMAP, now that they no longer have a minimum track
length of 3.
These changes make it possible to import the data into the latest
versions of COLMAP, as well as other tools that expect a similar format,
like gsplat.
Fixes #65.