Skip to content

Conversation

@nvdaes
Copy link
Contributor

@nvdaes nvdaes commented Jan 27, 2026

### Description

In PR nvaccess/addon-datastore#7368, a bug was introduced where security data was removed from json files

### Development approach

With assistance of Copilot, seems that when deleting translations the dictionary is mutated so that then some data is not added in the transformation.

So, instead of deleting translations directly, data is copied to a different dictionary and then added to json files as appropriate.

### Testing performed

Currently tests are been performed at

https://github.com/nvdaes/addon-datastore/actions/runs/21413861127

### Note

@seanbudd, if it's posible that I cannot way tonight until tests are finished. Please feel free to see results and proceed to merge if appropriate.

@seanbudd
Copy link
Member

This approach doesn't look right. Other data is what is being deleted, not just translations. The commit generated from testing still looks broken: nvdaes/addon-datastore@2b688a1. Please confirm testing before marking as ready

@seanbudd seanbudd marked this pull request as draft January 28, 2026 04:57
@nvdaes
Copy link
Contributor Author

nvdaes commented Jan 29, 2026

@seanbudd I think that the problem is not related to this repo. Imo we should handle reviewUrl, vtUrl and scanResult fields, not added to the regenerated json file.
But should we analyze again with VirusTotal and codeQL when the json is regenerated? I think that we should close this PR since seems it's useless, and for now you may revertPR nvaccess/addon-datastore#7368 if this won't be used soon, or decide what to do with scan results and codeQL analysis, if they should be performed again in the regeneration.
I'll wait for your feedback before closing this current PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants