Create action to virus scan all add-ons #4302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanbudd
commented
Sep 19, 2024
seanbudd
commented
Sep 19, 2024
seanbudd
commented
Sep 23, 2024
SaschaCowley
requested changes
Sep 23, 2024
|
Is it worth setting up an alias for |
|
Is it worth setting up an alias for jq -e --tab since that seems to be what we use most of the time? I think it might be harder than its worth at this point |
SaschaCowley
approved these changes
Sep 25, 2024
| fs.writeFileSync('reviewedAddons.json', stringified); | ||
| core.setFailed('VirusTotal analysis failed'); | ||
| fs.writeFileSync("reviewedAddons.json", stringified); | ||
| core.setFailed("VirusTotal analysis failed"); |
There was a problem hiding this comment.
Is this supposed to be here? Seems like analysis hasn't failed, but the add-on has been flagged?
There was a problem hiding this comment.
This is so individual submissions will fail if they are flagged. We probably should have different behaviour for group runs vs individual runs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VirusTotal scanning has been enabled for newly submitted add-ons.
This PR adds a GitHub action to scan all already submitted add-ons with VirusTotal.
When the scan runs, a PR is opened to add scan URLs to add-on metadata, and update the list of approved add-ons which have Virus scanning flagged.
Example PR: nvaccess#72
Example GitHub run: https://github.com/nvaccess/addon-datastore-staging/actions/runs/10986159260/job/30499090448
Latest GitHub run: https://github.com/nvaccess/addon-datastore-staging/actions/runs/11024324626/job/30617277974
Latest results PR: https://github.com/nvaccess/addon-datastore-staging/pull/73/files