fix(policy): condition shutdown ordering on fast reap - #726
Draft
maximilianigl wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COSMOS_SHUTDOWN_ON_NO_POLICY_REPLICASis disabled, allowing the controller to broadcast rolloutSTOPand break the shutdown cycleWhy
With fast reap disabled, payload-packer teardown can wait for rollout NCCL peers before the final policy unregister lets the controller send rollout
STOP. The policy waits for rollout while rollout waits for policy departure.Moving unregister first unconditionally would regress #709: with fast reap enabled, unregister arms controller SIGTERM before local policy cleanup completes. The shutdown order therefore follows the existing shared parsed setting.
Only rank 0 sends the unregister request; other policy ranks retain the existing idempotent no-op behavior.
Test plan
python -m pytest -q tests/test_multirank_shutdown.py— 64 passed, 2 subtests passedruff check cosmos_rl/policy/worker/rl_worker.py tests/test_multirank_shutdown.pyruff format --check cosmos_rl/policy/worker/rl_worker.py tests/test_multirank_shutdown.pygit diff --checkNot re-run on a distributed cluster.