-
Notifications
You must be signed in to change notification settings - Fork 87
Add polyp detection application #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add polyp detection application #654
Conversation
Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv can you look at the linting issues? |
Signed-off-by: Yiheng Wang <[email protected]>
Thanks @jjomier , the lint issue is fixed. I will update the draft PR for adding more useful operators, and then convert to |
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Hi @jjomier , could you please help to review this PR? Thanks in advance. |
Thanks @yiheng-wang-nv. There are still some linting errors. You can run do a |
Hi @yiheng-wang-nv could you please remove the |
Thanks @jjomier for the suggestions!
|
Signed-off-by: Yiheng Wang <[email protected]>
Hi @yiheng-wang-nv , Let's try to complete this PR and merge it. Thanks. |
@yiheng-wang-nv, I believe we are over-complicating this submission. Why don't we use the current polyp segmentation application but add the new ONNX model instead? Is the ONNX model publicly open or has it been fined tuned? |
Hi @jjomier , thanks for the suggestion. For this PR, the model I used is trained by myself with the real colon dataset, and the model is used for detection instead of segmentation. Therefore, we may not be able to use the existing model instead. |
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
3f046d2
to
fed019e
Compare
if(HOLOHUB_DOWNLOAD_DATASETS) | ||
include(holoscan_download_data) | ||
holoscan_download_data(polyp_detection_sample_app_data | ||
URL nvstaging/holoscan/polyp_detection_sample_app_data:1.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: the URL need to be replaced by a NGC catalog link
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
Hi @yiheng-wang-nv , @jjomier , May I know the remaining tasks of this PR? Thanks. |
Working on releasing the model first |
No description provided.