Skip to content

Add polyp detection application #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

yiheng-wang-nv
Copy link

No description provided.

Signed-off-by: Yiheng Wang <[email protected]>
@jjomier
Copy link
Contributor

jjomier commented Jan 10, 2025

@yiheng-wang-nv can you look at the linting issues?
Let us know when this is ready to review.

@yiheng-wang-nv
Copy link
Author

yiheng-wang-nv commented Jan 13, 2025

Thanks @jjomier , the lint issue is fixed. I will update the draft PR for adding more useful operators, and then convert to ready for review

@yiheng-wang-nv yiheng-wang-nv marked this pull request as ready for review January 17, 2025 13:10
Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv
Copy link
Author

Hi @jjomier , could you please help to review this PR? Thanks in advance.

@jjomier jjomier self-assigned this Jan 21, 2025
@jjomier
Copy link
Contributor

jjomier commented Jan 21, 2025

Thanks @yiheng-wang-nv.
Since we are using an ONNX model, why aren't you using the Holoscan ONNX inference operator instead of converting to TRT (that operator does the conversion automatically).? Ideally if we can using the base Holohub/Holoscan docker image that would be ideal. Why do we need Torch?

There are still some linting errors. You can run do a ./run lint if you want to check for the errors before commiting.

@tbirdso
Copy link
Contributor

tbirdso commented Jan 21, 2025

Hi @yiheng-wang-nv could you please remove the [draft] label if this PR is ready for review+merge?

@yiheng-wang-nv
Copy link
Author

Thanks @yiheng-wang-nv. Since we are using an ONNX model, why aren't you using the Holoscan ONNX inference operator instead of converting to TRT (that operator does the conversion automatically).? Ideally if we can using the base Holohub/Holoscan docker image that would be ideal. Why do we need Torch?

There are still some linting errors. You can run do a ./run lint if you want to check for the errors before commiting.

Thanks @jjomier for the suggestions!

  • I will check how to use the onnx inference operator.
  • As for the Holoscan docker image, do you have any references? I took the sam2 application for reference, thus used the pytorch base image.
  • As for the linting errors, I will fix them.

@Nic-Ma
Copy link

Nic-Ma commented Feb 16, 2025

Hi @yiheng-wang-nv ,

Let's try to complete this PR and merge it.

Thanks.

@jjomier
Copy link
Contributor

jjomier commented Feb 17, 2025

@yiheng-wang-nv, I believe we are over-complicating this submission. Why don't we use the current polyp segmentation application but add the new ONNX model instead? Is the ONNX model publicly open or has it been fined tuned?

@yiheng-wang-nv
Copy link
Author

current polyp segmentation application

Hi @jjomier , thanks for the suggestion. For this PR, the model I used is trained by myself with the real colon dataset, and the model is used for detection instead of segmentation. Therefore, we may not be able to use the existing model instead.

@yiheng-wang-nv yiheng-wang-nv force-pushed the add-real-colon-polyp-detection branch from 3f046d2 to fed019e Compare February 26, 2025 09:03
@yiheng-wang-nv yiheng-wang-nv changed the title [draft] add polyp detection application Add polyp detection application Feb 26, 2025
if(HOLOHUB_DOWNLOAD_DATASETS)
include(holoscan_download_data)
holoscan_download_data(polyp_detection_sample_app_data
URL nvstaging/holoscan/polyp_detection_sample_app_data:1.0.0
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: the URL need to be replaced by a NGC catalog link

@Nic-Ma
Copy link

Nic-Ma commented Mar 25, 2025

Hi @yiheng-wang-nv , @jjomier ,

May I know the remaining tasks of this PR?

Thanks.

@jjomier
Copy link
Contributor

jjomier commented Mar 25, 2025

Hi @yiheng-wang-nv , @jjomier ,

May I know the remaining tasks of this PR?

Thanks.

Working on releasing the model first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants