fix(operators): remove new default grx LSP mapping#2324
Merged
echasnovski merged 1 commit intonvim-mini:mainfrom Mar 20, 2026
Merged
fix(operators): remove new default grx LSP mapping#2324echasnovski merged 1 commit intonvim-mini:mainfrom
grx LSP mapping#2324echasnovski merged 1 commit intonvim-mini:mainfrom
Conversation
abeldekat
force-pushed
the
test_operators_nightly_new_gr_mapping
branch
from
cbe880b to
f1d4d5e
Compare
abeldekat
force-pushed
the
test_operators_nightly_new_gr_mapping
branch
from
f1d4d5e to
830d8f1
Compare
abeldekat
changed the title
grx LSP mapping
Member
Author
|
Shall I add the new mapping to MiniMax as |
Member
|
Thanks for the PR! Could you please more closely follow the 6a6a37e? I.e. almost the same set of changes and the almost the same commit message.
This is a bit early for MiniMax. Let's wait until the Neovim 0.12 release. Besides, I am not sure that |
Details: - Its presence conflicts with `gr` mapping.
abeldekat
force-pushed
the
test_operators_nightly_new_gr_mapping
branch
from
830d8f1 to
0f0937e
Compare
Member
Author
Done |
echasnovski
approved these changes
Mar 20, 2026
Member
echasnovski
left a comment
echasnovski
left a comment
There was a problem hiding this comment.
Thanks! Looks better now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
New builtin lsp mapping "grx" executes
vim.lsp.codelens.run()See PR 37689 in neovim/neovim
This causes test 'Replace works with
cmdheight=0' to fail:Can not use
child.get_screenshotbecause child process is blocked.In mini.operators, default
gr*LSP mappings are removedI have read CONTRIBUTING.md
I have read CODE_OF_CONDUCT.md