Skip to content

fix: =$= and =0= motions for calendar view #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

celsobenedetti
Copy link
Contributor

@celsobenedetti celsobenedetti commented May 24, 2025

Summary

This PR configures the $ and 0 mappings for the calendar view, so they take us to the last/first day of the week.

I just hacked this together to make it work. I'm happy to address any direction this should be taken.

Thank you!

Video demonstrating the problem on master 55b68bb

Kazam_screencast_00016.mp4

Video demonstrating the behavior on this branch

Kazam_screencast_00017.mp4

Related Issues

Closes #986

Changes

Configuring two new mappings for $ and 0 on the calendar view.

Checklist

I confirm that I have:

  • Followed the
    Conventional Commits
    specification
    (e.g., feat: add new feature, fix: correct bug,
    docs: update documentation).
  • My PR title also follows the conventional commits specification.
  • Updated relevant documentation, if necessary.
  • Thoroughly tested my changes.
  • Added tests (if applicable) and verified existing tests pass with
    make test.
  • Checked for breaking changes and documented them, if any.

Copy link
Member

@kristijanhusak kristijanhusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Generally looks good, but there are few edge cases that needs to be handled.

celsobenedetti and others added 2 commits May 27, 2025 12:17
Co-authored-by: Kristijan Husak <[email protected]>
Co-authored-by: Kristijan Husak <[email protected]>
@celsobenedetti
Copy link
Contributor Author

Thank you! Tested the suggestion locally and could find no bugs.

  • tested regular weeks
  • tested weeks that don't start on Sun
  • tested weeks that don't end on Sat

Copy link
Member

@kristijanhusak kristijanhusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kristijanhusak kristijanhusak merged commit 12680a3 into nvim-orgmode:master May 27, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar motions for =$= and =0= not behaving as expected
2 participants