Merged
Conversation
- Use DPB_EMPTY enum instead of hardcoded 0 when assigning dpb state - Remove redundant and self explanatory comments related to dpb state assignments - Remove comments related to MVC encoding
…om_needed_for_output`. Both flags are set to 0 (marking the picture as "not needed for output") immediately before the condition is evaluated. Because of this, checking whether the picture is "not needed for output" provides no meaningful value and can be removed.
…ictureEnd()`. Assigning the last DPB slot to the current picture when `DpbPictureEnd()` fails to provide one is incorrect. The last slot may still hold a valid picture that is either needed for reference or needed for output. If no slot is available for the current picture, it indicates a DPB management error.
Additional details and rationale are documented directly in the code comments.
Contributor
Author
|
@zlatinski @srinathkr-nv for review. |
zlatinski
approved these changes
Jan 29, 2026
Contributor
zlatinski
left a comment
zlatinski
left a comment
There was a problem hiding this comment.
LGTM. Thank you for the fixes, Raju!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a corner case in DPB management logic.
Additional details and rationale are documented directly in the code comments.