Changing roles to "region" & "group"#4
Open
weotch wants to merge 1 commit into
Open
Conversation
Owner
|
@weotch Sry for not replying earlier, I was out on holiday. I will take a look early next week! Thank you for the contribution 🙏 |
Author
|
👋 Any chance of getting this merged? Thanks! |
Author
|
FWIW, our ADA auditing company was satisfied with this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the roles that are used for the carousel and slides to match those that are currently used by https://www.w3.org/WAI/ARIA/apg/patterns/carousel/examples/carousel-1-prev-next/.
This came up when implementing this package on a client side. The ADA auditing firm said:
Also, thank you for releasing this package!