Enable privacy notification tray for screen sharing

[shikhak]

Filed bug: nwjs/nw.js#8156
To enable screen-sharing, these patches need to be undone.

[ayushmanchhabra]

Just want to clarify that screen sharing was already working and this PR fixes and enables the stop sharing button which was previously missing?

[ayushmanchhabra]

@rogerwang requesting your review, forgot to ping you here

[hthetiot]

I think you need to keep the return ui, or if not let's keep "#if 0" so up stream merge is easier.

[hthetiot]

Hello @GnorTech,
Thx for maintener work you have been doing recently.

Would it be possible to review this one.
I do believe we might need to keep lines I highlighted in comment, but i may be wrong.
#165 (comment)

[GnorTech]

The change to ShouldDisplayNotification is correct — removing is_nwjs_app() there will show the "Stop Sharing" button.

However, the change to GetDesktopCapturePermission should not be applied. That check auto-approves screen capture for NW.js apps, which is the expected behavior for desktop applications. Removing it would force users to click "Allow" on a permission dialog every time, which is unnecessary for a native desktop app.

[hthetiot]

Hello @shikhak, I hope you doing great.
Would it be possible to apply the review fixe above in you PR.
Alternatively if you wish I can make a separate PR.
Best regards