Skip to content

Fixed minHeight and maxHeight calculation on Windows #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: nw18
Choose a base branch
from
Open

Fixed minHeight and maxHeight calculation on Windows #50

wants to merge 3 commits into from

Conversation

ghostoy
Copy link
Member

@ghostoy ghostoy commented Nov 2, 2016

@rogerwang rogerwang force-pushed the nw18 branch 3 times, most recently from 41d754f to ddce6f7 Compare November 4, 2016 02:49
@rogerwang
Copy link
Member

Does upstream has this bug with Chrome Apps?

@rogerwang rogerwang closed this Nov 4, 2016
@rogerwang rogerwang reopened this Nov 4, 2016
@rogerwang rogerwang force-pushed the nw18 branch 4 times, most recently from dd7db35 to ff1427b Compare November 6, 2016 11:39
@ghostoy
Copy link
Member Author

ghostoy commented Nov 6, 2016

@rogerwang No. It only happens for NW.js. The root cause is that NW.js didn't call DwmExtendFrameIntoClientArea to make Windows update icons and titles automatically. Therefore the min / max height / width should not contain the glass insets.

@rogerwang rogerwang force-pushed the nw18 branch 5 times, most recently from 808f8b7 to 63ba438 Compare November 13, 2016 13:30
@rogerwang rogerwang force-pushed the nw18 branch 2 times, most recently from 8b8d0d3 to a3607ba Compare November 14, 2016 04:37
@rogerwang
Copy link
Member

rogerwang commented Nov 14, 2016 •
edited
Loading

This need further checking by me because the code of that function caused tricky regression in the past.

@rogerwang rogerwang force-pushed the nw18 branch 2 times, most recently from e8471f5 to bd57377 Compare November 21, 2016 05:50
rogerwang pushed a commit that referenced this pull request Dec 5, 2016
[Custom Tab] Fix a crash when getting a screenshot of a tab
edfcb48 
Since the screenshot taking happens 1 second later than onFinishLoad(),
there should not be any guarantee of whether the tab is alive or not.

BUG=667358

Review-Url: https://codereview.chromium.org/2523593003
Cr-Commit-Position: refs/heads/master@{#433724}
(cherry picked from commit 3bb40d3)

Review URL: https://codereview.chromium.org/2521863002 .

Cr-Commit-Position: refs/branch-heads/2924@{#50}
Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
GnorTech pushed a commit that referenced this pull request Jan 29, 2017
[Android] Disable "Add to Home Screen" for chrome://credits page
1995096 
Chrome scheme page (chrome://) and Chrome native scheme page
(chrome-native://) should not be allowed to add to home screen.

Check with url of a Custom Tab starts with chrome:// or
chrome-natvie://, if so disable the "Add to Home Screen" item for CCT
menu.

BUG=682620

(cherry picked from commit 0eab689)

Review-Url: https://codereview.chromium.org/2638423004
Cr-Original-Commit-Position: refs/heads/master@{#445235}
Cr-Commit-Position: refs/branch-heads/2987@{#50}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
rogerwang pushed a commit that referenced this pull request Mar 11, 2017
@lucasgadani
Avoid fetching RFH from nav handle for not committed navigations.
c1080fb 
For devtool use case there is only a need to check if hosts match,
so compareing frame tree node id instead of raw pointers will give
same result.

BUG=697991

Review-Url: https://codereview.chromium.org/2730873002
Cr-Commit-Position: refs/heads/master@{#454849}
(cherry picked from commit 9b5ea61)

[email protected],[email protected],[email protected]
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2740473003
Cr-Commit-Position: refs/branch-heads/3029@{#50}
Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech pushed a commit that referenced this pull request Apr 26, 2017
@wangxianzhu
Don't update descendant visual rects on border radius change
083dce5 
Border radius doesn't affect descendants' visual rects.
This fixes the "Check failed: parent_context.tree_builder_context->
is_actually_needed" failure when running
tools/perf/run_benchmark run rasterize_and_record_micro.top_25 --browser=debug --story-filter=plus
The failure was because the subtree was marked to update visual rects but
ancestors didn't update paint properties.

BUG=710665
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2821183002
Cr-Commit-Position: refs/heads/master@{#465093}

[email protected]
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2829673002
Cr-Commit-Position: refs/branch-heads/3071@{#50}
Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
GnorTech pushed a commit that referenced this pull request Aug 5, 2017
Chrome OS: Adjust size of a hyperlink on the EULA screen.
d36e48f 
This CL makes keyboard focus highlighting match the text size of a
hyperlink on the EULA screen.

[email protected]

(cherry picked from commit c2c6e0a)

Bug: 732324
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifbfed41f7c52e0089d780917a5431638a92d9476
Reviewed-on: https://chromium-review.googlesource.com/580431
Reviewed-by: Achuith Bhandarkar <[email protected]>
Commit-Queue: Alexander Alekseev <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#488786}
Reviewed-on: https://chromium-review.googlesource.com/585898
Reviewed-by: Alexander Alekseev <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#50}
Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech pushed a commit that referenced this pull request Sep 14, 2017
Incrementing VERSION to 62.0.3202.10
ff28287 
[email protected]

Change-Id: Ie712f56244bb0338e1db94539d35ac1b90f0ae22
Reviewed-on: https://chromium-review.googlesource.com/653759
Reviewed-by: [email protected] <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{#50}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech pushed a commit that referenced this pull request Oct 27, 2017
@beccahughes
Media Controls: Fix slider touch issue
94d371c 
This fixes a regression where touch/click events are not correctly
being picked up by the slider. This adds padding around the timeline
and volume slider which will pick up gestures in these areas. There
is no visual effect of this change.

BUG=773475

Change-Id: Idff48c259438bb776f6794d921625f5340744d1b
Reviewed-on: https://chromium-review.googlesource.com/721319
Reviewed-by: Mounir Lamouri <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#509350}(cherry picked from commit 6c57517)
Reviewed-on: https://chromium-review.googlesource.com/725290
Reviewed-by: Becca Hughes <[email protected]>
Cr-Commit-Position: refs/branch-heads/3239@{#50}
Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang pushed a commit that referenced this pull request Jan 29, 2018
@stevenjb
VPN: Disable autoconnect by default
dcf94bc 
[email protected]

(cherry picked from commit b556c19)

Bug: 803497
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I376899c280da4e017c729ebf462e9f30f24fb022
Reviewed-on: https://chromium-review.googlesource.com/877220
Commit-Queue: Steven Bennetts <[email protected]>
Reviewed-by: Kevin Cernekee <[email protected]>
Reviewed-by: Toni Barzic <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#530904}
Reviewed-on: https://chromium-review.googlesource.com/882549
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/3325@{#50}
Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech pushed a commit that referenced this pull request Mar 20, 2018
Expose onCheckIsTextEditor correctly through WebView object
c4cb61c 
View#onCheckIsTextEditor tells the framework whether the view object can
edit text or not.

We need to do plumbing work to ensure that WebView#onCheckIsTextEditor()
returns a correct value. This is a chromium side change.

Bug: 819420, b/74199870
Change-Id: Ifd93421b855f346d820af4d221863ce83b2e79e5
Reviewed-on: https://chromium-review.googlesource.com/952217
Commit-Queue: Changwan Ryu <[email protected]>
Reviewed-by: Bo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#541296}(cherry picked from commit 9195b0a)
Reviewed-on: https://chromium-review.googlesource.com/952035
Reviewed-by: Changwan Ryu <[email protected]>
Cr-Commit-Position: refs/branch-heads/3359@{#50}
Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
@rdcronin
[Merge m67][Extensions Bindings] Tweak messaging argument parsing
aeff192 
There was a bug where if the ID were passed as null or undefined (rather
than completely omitted), the message would fail to parse. Fix this, and
add a unittest.

Bug: 828664

[email protected]

(cherry picked from commit 7c723eb)

Change-Id: I92b0f071a1627322e12e8eaf0f5787ccd0793138
Reviewed-on: https://chromium-review.googlesource.com/1012601
Reviewed-by: Istiaque Ahmed <[email protected]>
Commit-Queue: Devlin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#550718}
Reviewed-on: https://chromium-review.googlesource.com/1015412
Reviewed-by: Devlin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3396@{#50}
Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang pushed a commit that referenced this pull request Jun 19, 2018
Do not induce kCrashOnUnexpectedURLChange if previous hostname is empty.
b4de322 
URLDidChangeWithoutDocumentChange should not be called if previous
document hostname is empty. This state is a bug, but there is no value
in crashing.

[email protected]

(cherry picked from commit c984463)

Bug: 845933
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I83ddc62ebc4211aa14f7819f8ea9a6d80d1b7e25
Reviewed-on: https://chromium-review.googlesource.com/1079368
Reviewed-by: Danyao Wang <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Commit-Queue: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#562941}
Reviewed-on: https://chromium-review.googlesource.com/1079816
Reviewed-by: Eugene But <[email protected]>
Cr-Commit-Position: refs/branch-heads/3440@{#50}
Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech pushed a commit that referenced this pull request Aug 4, 2018
Forward events to the tab strip.
f37fee3 
The shadow around the omnibox results popup eats mouse events.
Manually forward events occurring in the shadow area to the
underlying widget to fix the tab strip.

BUG=864963, 838667
[email protected]

(cherry picked from commit af7dcaa)

Change-Id: I5c6499f5d024863dad611f8670fb12e1a01ff073
Reviewed-on: https://chromium-review.googlesource.com/1144225
Commit-Queue: Avi Drissman <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#577293}
Reviewed-on: https://chromium-review.googlesource.com/1148792
Reviewed-by: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/branch-heads/3497@{#50}
Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang pushed a commit that referenced this pull request Sep 15, 2018
@clarkduvall
Fix web request proxy crash by moving ownership to ResourceContext
61a92ca 
The web request proxies will now be owned completely on the IO thread by
ResourceContext. This should prevent any handlers from being run after
the ResourceContext is destroyed.

Bug: 878366
Change-Id: I629d81597ee3ab3835a63ebe47cb97fa4497b36a
Reviewed-on: https://chromium-review.googlesource.com/1205470
Reviewed-by: Ken Rockot <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Commit-Queue: Clark DuVall <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#588692}(cherry picked from commit 86bc694)
Reviewed-on: https://chromium-review.googlesource.com/1207354
Reviewed-by: Clark DuVall <[email protected]>
Cr-Commit-Position: refs/branch-heads/3538@{#50}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang pushed a commit that referenced this pull request Oct 31, 2018
@jacobdufault-google
cros: Accessibility fixes for removing users on views-login
902f23d 
- Fix the label for the remove user button so it reads "Remove user"
- After hitting remove user read the warning message
- Increase the contrast for the remove user button.

[email protected]

(cherry picked from commit 7984efe)

Bug: 787489
Change-Id: I2003aaa0b63cda33e1a23ceb4b4d2bd55fbd531f
Reviewed-on: https://chromium-review.googlesource.com/c/1278140
Commit-Queue: Jacob Dufault <[email protected]>
Reviewed-by: Michael Wasserman <[email protected]>
Reviewed-by: Wenzhao (Colin) Zang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#599403}
Reviewed-on: https://chromium-review.googlesource.com/c/1284061
Reviewed-by: Jacob Dufault <[email protected]>
Cr-Commit-Position: refs/branch-heads/3578@{#50}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang pushed a commit that referenced this pull request Dec 18, 2018
@dalecurtis
Merge M72: "Release sink when AudioSourceProvider::SetClient() is cal…
38e8f7e 
…led."

There's currently no way to resume these sinks from html/js so there's
no point in restoring the sink state after disconnection. Specifically
you can't call MediaElementAudioSourceNode.disconnect() and expect the
underlying media element to be able to ever work again. See this demo:

http://storage.googleapis.com/dalecurtis/webaudio-test.html

Once AudioContext.createMediaElementSource(element) has been called on
an element, that element can never be used standalone again. It must
always be connected to the AudioContext to be used.

In fact it's actually causing unnecessary work when the elements are
destructed since removing the client respins the sink and mixer, etc.

BUG=905506,910951
TEST=passes cq.
R=​hongchan

Change-Id: I5ff7fc532545075d62859a30f96d17c83bff9d21
Reviewed-on: https://chromium-review.googlesource.com/c/1359092
Commit-Queue: Dale Curtis <[email protected]>
Reviewed-by: Hongchan Choi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#613346}(cherry picked from commit 391671c)
Reviewed-on: https://chromium-review.googlesource.com/c/1362296
Reviewed-by: Dale Curtis <[email protected]>
Cr-Commit-Position: refs/branch-heads/3626@{#50}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang pushed a commit that referenced this pull request Feb 10, 2019
Fix tab traversal order in Assistant.
9bb8581 
Summary of issue: Tab traversal within Assistant was very irregular,
the Assistant cards (backed by NavigableContents) would steal focus
when attempting to traverse the native view hierarchy. See video in
bug comments for example of issue.

Solution: Handle WebContentsDelegate::TakeFocus event to trigger a
clearing of native view focus in NavigableContentsView.

(cherry picked from commit 531da0e)

Bug: b:120682808
Change-Id: Ib571b3a1a6e9ccbc48d44fe29c67c6aa62aa85b0
Reviewed-on: https://chromium-review.googlesource.com/c/1407172
Commit-Queue: David Black <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Ken Rockot <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#626885}
Reviewed-on: https://chromium-review.googlesource.com/c/1444233
Cr-Commit-Position: refs/branch-heads/3683@{#50}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang pushed a commit that referenced this pull request Mar 24, 2019
@aawc
[M74]: Check enabled_ before getting a SafeBrowsingApiHandler instance
c3d24de 
R=drubery
[email protected]

(cherry picked from commit b11df6ef5e57d35cdf1707a30809e2d75613974a)

Bug: 940345,907280
Change-Id: I56bcae95a16e9b4235ac3b25986965ac764af009
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516042
Auto-Submit: Varun Khaneja <[email protected]>
Reviewed-by: Daniel Rubery <[email protected]>
Commit-Queue: Daniel Rubery <[email protected]>
Commit-Queue: Varun Khaneja <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#639613}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518448
Reviewed-by: Varun Khaneja <[email protected]>
Cr-Commit-Position: refs/branch-heads/3729@{#50}
Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghostoy @rogerwang