Skip to content

Fix empty hotkeys field in shortcut file props#96

Merged
TheJaredWilcurt merged 2 commits intonwutils:mainfrom
caumeira:patch-1
Apr 18, 2025
Merged

Fix empty hotkeys field in shortcut file props#96
TheJaredWilcurt merged 2 commits intonwutils:mainfrom
caumeira:patch-1

Conversation

@caumeira
Copy link
Copy Markdown
Contributor

When creating a shortcut without passing hotkey options, some apps break when read the shortcut file because the hotkey field is empty like the left example, but without the hotkey arguments in vb script, shortkey field has a corrent windows value witch is "None" as shown on right.

bento

Comment thread src/windows.vbs
Copy link
Copy Markdown
Member

@TheJaredWilcurt TheJaredWilcurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good find and solution.

@TheJaredWilcurt TheJaredWilcurt merged commit df15491 into nwutils:main Apr 18, 2025
6 checks passed
@TheJaredWilcurt
Copy link
Copy Markdown
Member

This code is released in v1.11.1.

You can update to it by running:

  • npm install --save create-desktop-shortcuts@1.11.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants