Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Capacitor Crystal Plugin #1130

Merged
merged 9 commits into from
Dec 9, 2024
Merged

Feature: Add Capacitor Crystal Plugin #1130

merged 9 commits into from
Dec 9, 2024

Conversation

edbzn
Copy link
Member

@edbzn edbzn commented Oct 9, 2024

This pull request adds an inference plugin for Capacitor.

Summary of changes

  • The configuration generator sets the plugin in nx.json instead of statically generating targets in the project.json:
{
  "plugins": ["@nxext/capacitor/plugin"]
}

This plugin is responsible for:

  • Detecting Capacitor configuration inside any project (capacitor.config.ts file).
  • Based on the detection, infer Capacitor commands (add, sync, open...).

Not included in this PR

  • A migration (or a generator) from project.json configuration to inferred tasks.

Copy link

nx-cloud bot commented Oct 9, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a22caa8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@edbzn edbzn marked this pull request as ready for review December 8, 2024 09:40
@edbzn edbzn requested a review from DominikPieper December 8, 2024 09:40
@edbzn edbzn merged commit b245d3c into main Dec 9, 2024
7 checks passed
@edbzn edbzn deleted the cap-plugin branch December 9, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant