Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/ticket 1159 nxext stencil vue integration #1160

Merged
merged 18 commits into from
Jan 29, 2025
Merged

Feature/ticket 1159 nxext stencil vue integration #1160

merged 18 commits into from
Jan 29, 2025

Conversation

NickersWeb
Copy link
Contributor

@NickersWeb NickersWeb commented Dec 10, 2024 •
edited
Loading

Nick W added 14 commits December 10, 2024 15:23
nxext#1159 package.json including @nx/vue for stencil vue integration
178f090
nxext#1159 versions.ts STENCIL_OUTPUTTARGET_VERSION including vue
327e3e1
nxext#1159 fetch-latest-versions.ts including @stencil/vue-output-target
5e2ce0f
nxext#1159 add-outputtarget/add-vue generator.ts for vue
e261df0
nxext#1159 schema.d.ts and schema.json OutputTargetType including vue
d8ebde8
nxext#1159 .github ISSUE_TEMPLATE - including Vue
b261e41
nxext#1159 add-outputtarget.ts outputtargetGenerator extend with addV…
7370578 
…ueGenerator, including related tests
nxext#1159 generators.md mention vue in @nxext/stencil:add-outputtarg…
b286f77 
…et section, likewise for outputType
nxext#1159 e2e stencil e2e library.test.ts - include test 'should gen…
4d2a0c3 
…erate vue lib'
nxext#1159 README.md mention vue as part of stencil integration
dfdba42
nxext#1159 pnpm format code
b236041
nxext#1159 generators.md outputType format
92a9bd0
nxext#1159 generators.md and json for stencil outputtarget
966d846
nxext#1159 generators.md stencil output target; including vue
2f64ac7
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Dec 10, 2024 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 4574429.

Command Status Duration Result
nx affected --target lint build test e2e ✅ Succeeded 3m 40s View ↗
nx-cloud record -- pnpm exec nx format:check ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-21 10:18:09 UTC

@NickersWeb
Copy link
Contributor Author

It was unclear how to build and test this locally. So please provide instructions on how to do that. So I may be able to resolve any issues.

@NickersWeb NickersWeb marked this pull request as ready for review December 10, 2024 16:22
@DominikPieper
Copy link
Member

@NickersWeb you could use the e2e test for that. There are playground scripts but I'm not sure they're still working. I havent used them some time

@NickersWeb
Copy link
Contributor Author

@DominikPieper As mentioned here: https://discord.com/channels/1143497901675401286/1314674305480790108/1316479200655442010 - I have encountered issues when trying to test these changes locally.

edbzn
edbzn reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@edbzn edbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for this. I think it would be nice to have e2e tests as well.

@DominikPieper DominikPieper merged commit 635947f into nxext:main Jan 29, 2025
7 checks passed
@NickersWeb NickersWeb deleted the feature/ticket-1159-nxext-stencil-vue-integration branch March 10, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edbzn edbzn edbzn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NickersWeb @DominikPieper @edbzn