#1168 replace autoDefineCustomElements with customElementsExportBehavior 'auto-define-custom-elements' #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om-elements autoDefineCustomElements true with customElementsExportBehavior 'auto-define-custom-elements', including tests (https://stenciljs.com/docs/custom-elements#customelementsexportbehavior)
|
View your CI Pipeline Execution ↗ for commit d5760e3.
☁️ Nx Cloud last updated this comment at |
edbzn
approved these changes
Jan 28, 2025
|
@NickersWeb looks good, you just need to run the formatter. That's why the pipeline is failing |
|
Commit message are not formatted correctly. |
@edbzn I'm seeing no documentation in the markdown files; is this in reference to .husky and commit-msg? If so, please describe how I can resolve this issue. |
|
We can do it ourself when squashing no worries |
|
@NickersWeb for future commits, you can just do "pnpm commit". The workflow then will ask for the needed informations :-) there's a commitizen workflow |
…get-dist-custom-elements-custom-elements-export-behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #1168