Commit df24f94
LF-16700 drm/bridge: it6263: Fix getting EDID for DRM_BRIDGE_ATTACH_NO_CONNECTOR case
If DRM_BRIDGE_ATTACH_NO_CONNECTOR flag is set when attaching the bridge,
this bridge driver won't create a DRM connector but instead relying on
other drivers to do that, i.e., a bridge connector is created by a DRM
driver. In that case, it6263_get_edid() should use the connector
parameter of it6263_bridge_edid_read() to get EDID instead of the
connector created by this driver for the !DRM_BRIDGE_ATTACH_NO_CONNECTOR
case and cached in the main struct it6263, since the latter one is not
initialized at all for the DRM_BRIDGE_ATTACH_NO_CONNECTOR case. Note
that it6263_bridge_edid_read(), as the drm_bridge_funcs::edid_read
callback, is supposed to be only called by bridge connector for the
DRM_BRIDGE_ATTACH_NO_CONNECTOR case. So, pass the connector parameter
from it6263_bridge_edid_read() to it6263_get_edid() and use it to get
get EDID to avoid accessing the uninitialized connector. While at it,
change the it6263_get_edid() function call in it6263_connector_get_modes()
accordingly.
Signed-off-by: Ji Luo <ji.luo@nxp.com>
Reviewed-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
Tested-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
Co-developed-by: Liu Ying <victor.liu@nxp.com>
Signed-off-by: Liu Ying <victor.liu@nxp.com>
Acked-by: Jason Liu <jason.hui.liu@nxp.com>1 parent d93cce0 commit df24f94
1 file changed
Lines changed: 5 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
594 | 594 | | |
595 | 595 | | |
596 | 596 | | |
597 | | - | |
| 597 | + | |
| 598 | + | |
598 | 599 | | |
599 | 600 | | |
600 | 601 | | |
601 | 602 | | |
602 | | - | |
| 603 | + | |
603 | 604 | | |
604 | 605 | | |
605 | 606 | | |
| |||
640 | 641 | | |
641 | 642 | | |
642 | 643 | | |
643 | | - | |
| 644 | + | |
644 | 645 | | |
645 | 646 | | |
646 | 647 | | |
| |||
871 | 872 | | |
872 | 873 | | |
873 | 874 | | |
874 | | - | |
| 875 | + | |
875 | 876 | | |
876 | 877 | | |
877 | 878 | | |
| |||
0 commit comments