Fix a handful of compiler warnings#488
Merged
nxpfrankli merged 6 commits intonxp-imx:masterfrom Aug 19, 2025
Merged
Conversation
This change is done to be able to drop a few c-style casts without having to replace them by a `const_cast`. Signed-off-by: Markus Prasser <markuspg@users.noreply.github.com>
Signed-off-by: Markus Prasser <markuspg@users.noreply.github.com>
Signed-off-by: Markus Prasser <markuspg@users.noreply.github.com>
Signed-off-by: Markus Prasser <markuspg@users.noreply.github.com>
Signed-off-by: Markus Prasser <markuspg@users.noreply.github.com>
Signed-off-by: Markus Prasser <markuspg@users.noreply.github.com>
markuspg
commented
Aug 18, 2025
|
|
||
| int i = 0; | ||
|
|
||
| int ret = -1; |
Contributor
Author
There was a problem hiding this comment.
(In theory) ret could return an uninitialized value. To avoid this it is initialized explicitly and for following best practises its scope is being reduced additionally.
|
|
||
| //trim left space | ||
| while (cmd[pos] == separate && pos < cmd.size()) | ||
| while (pos < cmd.size() && cmd[pos] == separate) |
Contributor
Author
There was a problem hiding this comment.
LLVM rightly hinted that pos should be checked for its validity before using it to access the string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request does nothing more than fixing a few minor bugs regarding error messages and a possible uninitialized return value. Otherwise it's only about reducing compiler warnings.