Fix progress information be hidden when run in docker without tty#500
Merged
nxpfrankli merged 2 commits intonxp-imx:masterfrom Jan 21, 2026
Merged
Fix progress information be hidden when run in docker without tty#500nxpfrankli merged 2 commits intonxp-imx:masterfrom
nxpfrankli merged 2 commits intonxp-imx:masterfrom
Conversation
If no tty, ioctl(0, TIOCGWINSZ, &w) will fail and w.ws_col will be a garbage value which not stable, program's behavior should not depend on UB(undefined behavior) which maybe e.g. in docker container behave totally different. Signed-off-by: Larry Shen <larry.shen@nxp.com>
Use DISABLE_SUMMARY=true to disable summary line to avoid not so useful information in automation like LAVA. Signed-off-by: Larry Shen <larry.shen@nxp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detail see #499, this PR resolve windows compatibility.