import new opcode: jumpc, jump, loadc#5
Open
vjardin wants to merge 2 commits into
Open
Conversation
Add 'load conditional', 'jump condidional' and 'jump' to PBI instructions. Signed-off-by: Rabeeh Khoury <rabeeh@solid-run.com> Signed-off-by: Vincent Jardin <vjardin@free.fr>
Apply few hints based on new opcode from the former commit. A proper support based on the seciont 8.2.1 PBI Command List of LX2160ARM.pdf would be needed. Signed-off-by: Vincent Jardin <vjardin@free.fr>
Contributor
|
@vjardin, thanks for the PR! Is there any use case that you want to accomplish using these new commands? Are you planning to submit any other patch which uses these new instructions? Also, would you mind adding the disassemble portion for jump and jumpc and not just the hints? Thanks! |
Contributor
|
Hi Vincent, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main work was done by Rabeeh from:
https://github.com/SolidRun/lx2160a_build/blob/develop-ls-6.6.52-2.2.0/patches/rcw/0002-add-loadc-jumpc-and-jump-to-pbi-instructions.patch
Let's add some hints and typo fix for the disassemble case with a 2nd commit.
TODO: Based on some new use cases, some opcodes from the "Table 27. PBI Command Summary" of LX2160ARM.pdf could be added.
Table 27. PBI Command Summary
Block Copy Commands
Special Load Commands
Control Commands