Add deploymentID, AWS settings, update deps and go to 1.23 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norkans7
changed the title
rowanseymour
requested changes
Dec 13, 2024
testsuite/testdata.go
Outdated
| @@ -31,7 +31,7 @@ func InsertChannel(rt *runtime.Runtime, uuid models.ChannelUUID, orgID models.Or | |||
| func InsertContact(rt *runtime.Runtime, orgID models.OrgID, name string) models.ContactID { | |||
| row := rt.DB.QueryRow( | |||
| `INSERT INTO contacts_contact(uuid, org_id, name, status, ticket_count, is_active, created_on, modified_on) | |||
| VALUES($1, $2, $3, 'A', 1, TRUE, NOW(), NOW()) RETURNING id`, uuids.New(), orgID, name, | |||
| VALUES($1, $2, $3, 'A', 1, TRUE, NOW(), NOW()) RETURNING id`, uuids.NewV7(), orgID, name, | |||
There was a problem hiding this comment.
what about messages?
There was a problem hiding this comment.
I found v7 is used for channel logs only
There was a problem hiding this comment.
I think we should probably switch messages... but yeah for now it's only channel logs
web/client.go
Outdated
| @@ -30,7 +30,7 @@ type Client struct { | |||
|
|
|||
| func NewClient(s *Server, sock httpx.WebSocket, channel *models.Channel) *Client { | |||
| c := &Client{ | |||
| id: string(uuids.New()), | |||
| id: string(uuids.NewV7()), | |||
norkans7
force-pushed
the
add-deployment-ID
branch
from
f037db4 to
0d40d03
Compare
rowanseymour
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.