Fix button URLs for WA templates

[norkans7]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.43%. Comparing base (d9467e3) to head (2a7887a).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #720      +/-   ##
==========================================
+ Coverage   74.41%   74.43%   +0.02%     
==========================================
  Files         110      110              
  Lines       13335    13336       +1     
==========================================
+ Hits         9923     9927       +4     
+ Misses       2690     2689       -1     
+ Partials      722      720       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rowanseymour]

Not convinced we've modeled this correctly since we now need to infer component type from param type... and these params should be just type text.. param type was just supposed to tell the editor what kinda of widget to display. Maybe templating should include component type?

[norkans7]

So we could add the component type to the components we save? in addition to the content and params keys?

[norkans7]

At least that is needed for the buttons

[norkans7]

I tied adding the type to components nyaruka/rapidpro#5111 however that will require we change the

https://github.com/nyaruka/goflow/blob/545576482f9968644052b66f00544c972aa1cc33/flows/msg.go#L177

instead of

Params_    map[string][]TemplateParam `json:"params,omitempty"`

We have a array of components

Components_ []TemplateComponen

type TemplateComponen struct {
   Name string // what was used as key in the previous map
   Type string
   Params []TemplateParam
}

And that could make the loop

courier/handlers/meta/whatsapp/templates.go

Line 60 in d9467e3

for _, k := range compKeys {

easier as well